From: Greg KH <gregkh@linuxfoundation.org>
To: hoff.benjamin.k@gmail.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: hid: allow dynamic interval configuration via configfs
Date: Tue, 29 Apr 2025 15:48:24 +0200 [thread overview]
Message-ID: <2025042944-velvet-underwire-e0f5@gregkh> (raw)
In-Reply-To: <20250429133310.353977-1-hoff.benjamin.k@gmail.com>
On Tue, Apr 29, 2025 at 09:33:10AM -0400, hoff.benjamin.k@gmail.com wrote:
> From: Ben Hoff <hoff.benjamin.k@gmail.com>
>
> This patch adds support for dynamically configuring the polling interval
> (bInterval) for HID function drivers using configfs. This enables
> custom HID gadgets with user-specified poll rates without recompilation.
But you changed the default from:
> - .bInterval = 4, /* FIXME: Add this field in the
> - * HID gadget configuration?
> - * (struct hidg_func_descriptor)
> - */
to:
> + opts->interval = 10;
do you mean to do that without documenting it?
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-29 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 13:33 [PATCH] usb: gadget: hid: allow dynamic interval configuration via configfs hoff.benjamin.k
2025-04-29 13:48 ` Greg KH [this message]
2025-04-29 13:50 ` Krishna Kurapati
2025-04-29 14:11 ` Ben Hoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042944-velvet-underwire-e0f5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hoff.benjamin.k@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox