public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dave Penkler <dpenkler@gmail.com>
Cc: linux-usb@vger.kernel.org, guido.kiener@rohde-schwarz.com,
	stable@vger.kernel.org
Subject: Re: [PATCH 0/3 V3] usb: usbtmc: Fix erroneous ioctl returns
Date: Thu, 1 May 2025 17:26:37 +0200	[thread overview]
Message-ID: <2025050156-murkiness-undecided-4c81@gregkh> (raw)
In-Reply-To: <20250427074750.26447-1-dpenkler@gmail.com>

On Sun, Apr 27, 2025 at 09:47:50AM +0200, Dave Penkler wrote:
> Recent tests with timeouts > INT_MAX produced random error returns
> with usbtmc_get_stb. This was caused by assigning the return value
> of wait_event_interruptible_timeout to an int which overflowed to
> negative values. Also return value on success was the remaining
> number of jiffies instead of 0.
> 
> These patches fix all the cases where the return of
> wait_event_interruptible_timeout was assigned to an int and
> the case of the remaining jiffies return in usbtmc_get_stb.
> 
> Patch 1: Fixes usbtmc_get_stb 
> Patch 2: Fixes usbtmc488_ioctl_wait_srq
> Patch 3: Fixes usbtmc_generic_read
> 
> Dave Penkler (3):
>   usb: usbtmc: Fix erroneous get_stb ioctl error returns
>   usb: usbtmc: Fix erroneous wait_srq ioctl return
>   usb: usbtmc: Fix erroneous generic_read ioctl return
> 
>  drivers/usb/class/usbtmc.c | 53 ++++++++++++++++++++++----------------
>  1 file changed, 31 insertions(+), 22 deletions(-)
> 
> --
> Changes V1 => V2 Add cc to stable line
>         V2 => V3 Add susbsystem to cover letter
> 2.49.0
> 
> 

I'm confused, I don't see a full v3 set of patches here.  Look at what
ended up on the list:
	https://lore.kernel.org/all/20250427074750.26447-1-dpenkler@gmail.com/

That's just the cover letter?

Can you try again?  Something seems to have gotten lost.

thanks,

greg k-h

  reply	other threads:[~2025-05-01 15:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-27  7:47 [PATCH 0/3 V3] usb: usbtmc: Fix erroneous ioctl returns Dave Penkler
2025-05-01 15:26 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-05-02  7:09 Dave Penkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025050156-murkiness-undecided-4c81@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dpenkler@gmail.com \
    --cc=guido.kiener@rohde-schwarz.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox