From: Greg KH <gregkh@linuxfoundation.org>
To: Zongmin Zhou <min_halo@163.com>
Cc: rafael@kernel.org, dakr@kernel.org, markgross@kernel.org,
arnd@arndb.de, eric.piel@tremplin-utc.net,
valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Zongmin Zhou <zhouzongmin@kylinos.cn>
Subject: Re: [PATCH 1/2] driver core:add device's platform_data set for faux device
Date: Thu, 8 May 2025 11:45:20 +0200 [thread overview]
Message-ID: <2025050854-breeching-had-c9b3@gregkh> (raw)
In-Reply-To: <b03b374bc3adad275893e2ad60d4bf5a0ad358e3.1746662386.git.zhouzongmin@kylinos.cn>
On Thu, May 08, 2025 at 05:11:47PM +0800, Zongmin Zhou wrote:
> From: Zongmin Zhou <zhouzongmin@kylinos.cn>
>
> Most drivers based on platform bus may have specific data
> for the device.And will get this specific data to use
> after device added.
> So keep the setting for device's platform_data is necessary
> for converting platform device to faux device.
I do not understand, why not just use the platform_data field directly
in the faux device structure? Why change all callers to now have to
keep track of an additional pointer in these create functions? That
just adds complexity for everyone when almost no one will need it.
thanks,
greg k-h
next prev parent reply other threads:[~2025-05-08 9:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 9:11 [PATCH 0/2] some changes based on faux bus Zongmin Zhou
2025-05-08 9:11 ` [PATCH 1/2] driver core:add device's platform_data set for faux device Zongmin Zhou
2025-05-08 9:45 ` Greg KH [this message]
2025-05-09 2:41 ` Zongmin Zhou
2025-05-21 10:51 ` Greg KH
2025-05-28 9:21 ` Zongmin Zhou
2025-05-08 9:11 ` [PATCH 2/2] usbip: convert to use faux_device Zongmin Zhou
2025-05-09 10:42 ` kernel test robot
2025-06-04 6:54 ` [PATCH v2] " Zongmin Zhou
2025-06-10 15:15 ` Shuah Khan
2025-06-19 11:02 ` Greg KH
2025-06-19 11:01 ` Greg KH
2025-06-20 2:16 ` Zongmin Zhou
2025-06-20 4:29 ` Greg KH
2025-06-20 9:19 ` Zongmin Zhou
2025-06-20 9:27 ` Greg KH
2025-06-20 17:26 ` Shuah Khan
2025-06-24 3:21 ` Zongmin Zhou
2025-07-01 22:56 ` Shuah Khan
2025-07-02 2:12 ` Zongmin Zhou
2025-07-02 23:54 ` Shuah Khan
2025-07-03 6:04 ` Zongmin Zhou
2025-07-08 18:16 ` Shuah Khan
2025-07-09 9:07 ` Zongmin Zhou
2025-07-09 10:06 ` Greg KH
2025-07-09 14:20 ` Alan Stern
2025-07-09 21:49 ` Shuah Khan
2025-07-09 21:57 ` Shuah Khan
2025-07-10 14:06 ` Alan Stern
2025-07-10 20:33 ` Shuah Khan
2025-07-11 5:56 ` Greg KH
2025-07-14 5:31 ` Zongmin Zhou
2025-07-09 21:33 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025050854-breeching-had-c9b3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dakr@kernel.org \
--cc=eric.piel@tremplin-utc.net \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=min_halo@163.com \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
--cc=zhouzongmin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).