From: Greg KH <gregkh@linuxfoundation.org>
To: Jake Rice <jake@jakerice.dev>
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] usb: storage: Add blockbuffer ptr to info struct of sddr09 driver
Date: Fri, 9 May 2025 16:44:12 +0200 [thread overview]
Message-ID: <2025050927-bring-gusty-e850@gregkh> (raw)
In-Reply-To: <20250506191531.3326-1-jake@jakerice.dev>
On Tue, May 06, 2025 at 03:15:31PM -0400, Jake Rice wrote:
> Hi all,
>
> This patch updates the sddr09 driver to allocate a reusable block
> buffer. Unfortunately, I don't have access to the SDDR-00 hardware
> (which I know is pretty ancient), so I'm requesting testing from anyone who does.
> Please let me now if the patch causes any issues or improves performance.
>
> Best,
> Jake
>
> ---
> Currently, upon every write the block buffer is allocated and freed which is
> computationally expensive. With this implementation, a buffer pointer
> is added as a member to the info struct and allocated when the card
> information is read. The buffer is freed during desconstruction if
> necessary.
As Alan said, this is really slow hardware so I doubt allocating/free
the buffer will even be noticeable. Why make this change at all if you
don't have access to the hardware to test it?
thanks,
greg k-h
next prev parent reply other threads:[~2025-05-09 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 19:15 [RFC PATCH] usb: storage: Add blockbuffer ptr to info struct of sddr09 driver Jake Rice
2025-05-07 18:29 ` Alan Stern
2025-05-09 14:44 ` Greg KH [this message]
2025-05-09 16:40 ` Jake Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025050927-bring-gusty-e850@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jake@jakerice.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox