From: Siddarth Gundu <siddarthsgml@gmail.com>
To: b-liu@ti.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: skhan@linuxfoundation.org, Siddarth Gundu <siddarthsgml@gmail.com>
Subject: [PATCH] usb: musb: Fix signed integer overflow
Date: Sun, 11 May 2025 02:42:17 +0530 [thread overview]
Message-ID: <20250510211217.122790-1-siddarthsgml@gmail.com> (raw)
Shifting 1 << 31 on a 32-bit int causes signed integer overflow, which
leads to undefined behavior.
Cast 1 to u32 before performing the shift, eliminating the
undefined behavior.
Signed-off-by: Siddarth Gundu <siddarthsgml@gmail.com>
---
drivers/usb/musb/cppi_dma.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/cppi_dma.h b/drivers/usb/musb/cppi_dma.h
index 3606be897cb2..33bf5f83f08d 100644
--- a/drivers/usb/musb/cppi_dma.h
+++ b/drivers/usb/musb/cppi_dma.h
@@ -38,7 +38,7 @@ struct cppi_rx_stateram {
};
/* hw_options bits in CPPI buffer descriptors */
-#define CPPI_SOP_SET ((u32)(1 << 31))
+#define CPPI_SOP_SET ((u32)1 << 31)
#define CPPI_EOP_SET ((u32)(1 << 30))
#define CPPI_OWN_SET ((u32)(1 << 29)) /* owned by cppi */
#define CPPI_EOQ_MASK ((u32)(1 << 28))
@@ -48,7 +48,7 @@ struct cppi_rx_stateram {
#define CPPI_RECV_PKTLEN_MASK 0xFFFF
#define CPPI_BUFFER_LEN_MASK 0xFFFF
-#define CPPI_TEAR_READY ((u32)(1 << 31))
+#define CPPI_TEAR_READY ((u32)1 << 31)
/* CPPI data structure definitions */
--
2.43.0
next reply other threads:[~2025-05-10 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 21:12 Siddarth Gundu [this message]
2025-05-11 5:52 ` [PATCH] usb: musb: Fix signed integer overflow Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250510211217.122790-1-siddarthsgml@gmail.com \
--to=siddarthsgml@gmail.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox