From: Kees Cook <kees@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Wang <jasowang@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Cosmin Ratiu <cratiu@nvidia.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Maxim Georgiev <glipus@gmail.com>,
netdev@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Mike Christie <michael.christie@oracle.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Maurizio Lombardi <mlombard@redhat.com>,
Dmitry Bogdanov <d.bogdanov@yadro.com>,
Mingzhe Zou <mingzhe.zou@easystack.cn>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Lei Yang <leiyang@redhat.com>, Ido Schimmel <idosch@nvidia.com>,
Samuel Mendoza-Jonas <sam@mendozajonas.com>,
Paul Fertser <fercerpav@gmail.com>,
Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Hayes Wang <hayeswang@realtek.com>,
Douglas Anderson <dianders@chromium.org>,
Grant Grundler <grundler@chromium.org>,
Jay Vosburgh <jv@jvosburgh.net>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Jiri Pirko <jiri@resnulli.us>,
Aleksander Jan Bajkowski <olek2@wp.pl>,
Philipp Hahn <phahn-oss@avm.de>,
Eric Biggers <ebiggers@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Ahmed Zaki <ahmed.zaki@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Xiao Liang <shaw.leon@gmail.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-wpan@vger.kernel.org, linux-usb@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH net-next v2 8/8] net: core: Convert dev_set_mac_address_user() to use struct sockaddr_storage
Date: Tue, 27 May 2025 11:43:08 -0700 [thread overview]
Message-ID: <202505271142.EA78EAB04@keescook> (raw)
In-Reply-To: <e1429351-3c9b-40e0-b50d-de6527d0a05b@redhat.com>
On Tue, May 27, 2025 at 09:02:28AM +0200, Paolo Abeni wrote:
> On 5/21/25 10:46 PM, Kees Cook wrote:
> > diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
> > index fff13a8b48f1..616479e71466 100644
> > --- a/net/core/dev_ioctl.c
> > +++ b/net/core/dev_ioctl.c
> > @@ -572,9 +572,11 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, void __user *data,
> > return dev_set_mtu(dev, ifr->ifr_mtu);
> >
> > case SIOCSIFHWADDR:
> > - if (dev->addr_len > sizeof(struct sockaddr))
> > + if (dev->addr_len > sizeof(ifr->ifr_hwaddr))
> > return -EINVAL;
> > - return dev_set_mac_address_user(dev, &ifr->ifr_hwaddr, NULL);
> > + return dev_set_mac_address_user(dev,
> > + (struct sockaddr_storage *)&ifr->ifr_hwaddr,
> > + NULL);
>
> Side note for a possible follow-up: the above pattern is repeated a
> couple of times: IMHO consolidating it into an helper would be nice.
Yeah, I will look at that.
> Also such helper could/should explicitly convert ifr->ifr_hwaddr to
> sockaddr_storage and avoid the cast.
It's UAPI, so it looked verrrry painful to change.
--
Kees Cook
next prev parent reply other threads:[~2025-05-27 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 20:46 [PATCH net-next v2 0/8] net: Convert dev_set_mac_address() to struct sockaddr_storage Kees Cook
2025-05-21 20:46 ` [PATCH net-next v2 1/8] net: core: Convert inet_addr_is_any() to sockaddr_storage Kees Cook
2025-05-21 20:46 ` [PATCH net-next v2 2/8] net: core: Switch netif_set_mac_address() to struct sockaddr_storage Kees Cook
2025-05-21 20:46 ` [PATCH net-next v2 3/8] net/ncsi: Use struct sockaddr_storage for pending_mac Kees Cook
2025-05-21 20:46 ` [PATCH net-next v2 4/8] ieee802154: Use struct sockaddr_storage with dev_set_mac_address() Kees Cook
2025-05-21 20:46 ` [PATCH net-next v2 5/8] net: usb: r8152: Convert to use struct sockaddr_storage internally Kees Cook
2025-05-21 20:46 ` [PATCH net-next v2 6/8] net: core: Convert dev_set_mac_address() to struct sockaddr_storage Kees Cook
2025-05-21 20:46 ` [PATCH net-next v2 7/8] rtnetlink: do_setlink: Use " Kees Cook
2025-05-21 20:46 ` [PATCH net-next v2 8/8] net: core: Convert dev_set_mac_address_user() to use " Kees Cook
2025-05-21 23:07 ` Gustavo A. R. Silva
2025-05-27 7:02 ` Paolo Abeni
2025-05-27 18:43 ` Kees Cook [this message]
2025-05-27 7:10 ` [PATCH net-next v2 0/8] net: Convert dev_set_mac_address() to " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505271142.EA78EAB04@keescook \
--to=kees@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alex.aring@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=ardb@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=cratiu@nvidia.com \
--cc=d.bogdanov@yadro.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=dianders@chromium.org \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=glipus@gmail.com \
--cc=grundler@chromium.org \
--cc=gustavoars@kernel.org \
--cc=haiyangz@microsoft.com \
--cc=hayeswang@realtek.com \
--cc=hch@lst.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kch@nvidia.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=kys@microsoft.com \
--cc=leiyang@redhat.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux@treblig.org \
--cc=martin.petersen@oracle.com \
--cc=mgurtovoy@nvidia.com \
--cc=michael.christie@oracle.com \
--cc=mingzhe.zou@easystack.cn \
--cc=miquel.raynal@bootlin.com \
--cc=mlombard@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
--cc=phahn-oss@avm.de \
--cc=sagi@grimberg.me \
--cc=sam@mendozajonas.com \
--cc=sdf@fomichev.me \
--cc=shaw.leon@gmail.com \
--cc=stefan@datenfreihafen.org \
--cc=target-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vladimir.oltean@nxp.com \
--cc=wei.liu@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox