[PATCH] Add Marvell ML352 to drivers/usb/serial/option.c

[PATCH] Add Marvell ML352 to drivers/usb/serial/option.c

[Michael Wyraz]

Add the device id of the Marvell ML352 to option.c so that the
device is recognized as usb-serial device.

Signed-off-by: Michael Wyraz <michael@wyraz.de>
---
  drivers/usb/serial/option.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 5cd26dac2069..3bfdab641369 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -619,6 +619,10 @@ static void option_instat_callback(struct urb *urb);
  /* Luat Air72*U series based on UNISOC UIS8910 uses UNISOC's vendor ID */
  #define LUAT_PRODUCT_AIR720U            0x4e00

+/* Marvell products */
+#define MARVELL_VENDOR_ID            0x1286
+#define MARVELL_PRODUCT_ML352        0x4e3c
+
  /* Device flags */

  /* Highest interface number which can be used with NCTRL() and RSVD() */
@@ -2434,6 +2438,7 @@ static const struct usb_device_id option_ids[] = {
      { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, 
SIERRA_PRODUCT_EM9191, 0xff, 0, 0) },
      { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, 
TOZED_PRODUCT_LT70C, 0xff, 0, 0) },
      { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, 
LUAT_PRODUCT_AIR720U, 0xff, 0, 0) },
+    { USB_DEVICE(MARVELL_VENDOR_ID, MARVELL_PRODUCT_ML352) },
      { USB_DEVICE_INTERFACE_CLASS(0x1bbb, 0x0530, 0xff),            /* 
TCL IK512 MBIM */
        .driver_info = NCTRL(1) },
      { USB_DEVICE_INTERFACE_CLASS(0x1bbb, 0x0640, 0xff),            /* 
TCL IK512 ECM */
-- 
2.49.0

Re: [PATCH] Add Marvell ML352 to drivers/usb/serial/option.c

[Greg KH]

On Wed, Jun 04, 2025 at 07:40:16AM +0200, Michael Wyraz wrote:
> 
> Add the device id of the Marvell ML352 to option.c so that the
> device is recognized as usb-serial device.
> 
> Signed-off-by: Michael Wyraz <michael@wyraz.de>
> ---
>  drivers/usb/serial/option.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 5cd26dac2069..3bfdab641369 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -619,6 +619,10 @@ static void option_instat_callback(struct urb *urb);
>  /* Luat Air72*U series based on UNISOC UIS8910 uses UNISOC's vendor ID */
>  #define LUAT_PRODUCT_AIR720U            0x4e00
> 
> +/* Marvell products */
> +#define MARVELL_VENDOR_ID            0x1286
> +#define MARVELL_PRODUCT_ML352        0x4e3c
> +
>  /* Device flags */
> 
>  /* Highest interface number which can be used with NCTRL() and RSVD() */
> @@ -2434,6 +2438,7 @@ static const struct usb_device_id option_ids[] = {
>      { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID,
> SIERRA_PRODUCT_EM9191, 0xff, 0, 0) },
>      { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C,
> 0xff, 0, 0) },
>      { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, LUAT_PRODUCT_AIR720U,
> 0xff, 0, 0) },
> +    { USB_DEVICE(MARVELL_VENDOR_ID, MARVELL_PRODUCT_ML352) },
>      { USB_DEVICE_INTERFACE_CLASS(0x1bbb, 0x0530, 0xff),            /* TCL
> IK512 MBIM */
>        .driver_info = NCTRL(1) },
>      { USB_DEVICE_INTERFACE_CLASS(0x1bbb, 0x0640, 0xff),            /* TCL
> IK512 ECM */
> -- 
> 2.49.0
> 
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] Add Marvell ML352 to drivers/usb/serial/option.c

[Michael Wyraz]

Add the device id of the Marvell ML352 to option.c so that the
device is recognized as usb-serial device.

Signed-off-by: Michael Wyraz <michael@wyraz.de>
---
 drivers/usb/serial/option.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 5cd26dac2069..3bfdab641369 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -619,6 +619,10 @@ static void option_instat_callback(struct urb *urb);
 /* Luat Air72*U series based on UNISOC UIS8910 uses UNISOC's vendor ID */
 #define LUAT_PRODUCT_AIR720U			0x4e00
 
+/* Marvell products */
+#define MARVELL_VENDOR_ID			0x1286
+#define MARVELL_PRODUCT_ML352		0x4e3c
+
 /* Device flags */
 
 /* Highest interface number which can be used with NCTRL() and RSVD() */
@@ -2434,6 +2438,7 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0, 0) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C, 0xff, 0, 0) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, LUAT_PRODUCT_AIR720U, 0xff, 0, 0) },
+	{ USB_DEVICE(MARVELL_VENDOR_ID, MARVELL_PRODUCT_ML352) },
 	{ USB_DEVICE_INTERFACE_CLASS(0x1bbb, 0x0530, 0xff),			/* TCL IK512 MBIM */
 	  .driver_info = NCTRL(1) },
 	{ USB_DEVICE_INTERFACE_CLASS(0x1bbb, 0x0640, 0xff),			/* TCL IK512 ECM */
-- 
2.49.0

Re: [PATCH] Add Marvell ML352 to drivers/usb/serial/option.c

[Johan Hovold]

On Wed, Jun 18, 2025 at 10:06:15AM +0200, Michael Wyraz wrote:
> Add the device id of the Marvell ML352 to option.c so that the
> device is recognized as usb-serial device.
> 
> Signed-off-by: Michael Wyraz <michael@wyraz.de>

Thanks for the patch. Looks good, but we may not want to bind to every
interface of the device.

Can you please post the output of 'usb-devices' for this device? I
assume it has more than one interface, do what each interface is used
for?

If you end up resending, please use the common prefix in Subject, for
example:

	USB: serial: option: add support for Marvell ML352 

(e.g. as can been seen by running 'git log --oneline' on the files
you're changing).

Johan