From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5963027A133 for ; Thu, 5 Jun 2025 17:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749145990; cv=none; b=rrdAKU9BUsias3v7x/O/FOxX69ysBEF0Dv+HOxyydX+LQid07fiyXd0DHHYOhdVpZj5J1IlGJN018f2lgJ5vzfKDBka9zv7EA44VqeHPVQdwrSXcaIKYHaq5niH0jADra4RVsJYh25kgAeg1ZT1/szaCQ5ryBzIjecAA2h/18Ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749145990; c=relaxed/simple; bh=HkpzCJY6QMUo/A2tmF9l8NRgkFwGl+Bw/RVcSwiZ3nc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tXOfxUoLnhb8t5VfNmg0zIBuInsRX9nNoazhcq0zUp5UL7+ZWjyKH7ozalDHO6KylwaVKHprfR3sPI5ylPdOeati3h/B093+Lgq2qzqll7gzShnrVGa2CeANBUWM0C8HftfEK0egE3FJXnAQSVANG/Qi521yTPNGPvEEZEZTZU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=mAIbvnSb; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mAIbvnSb" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5535652f42cso1341145e87.2 for ; Thu, 05 Jun 2025 10:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1749145985; x=1749750785; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IAddCa1zo14U93p/hxz3tXNuMoufL4dFoj1aELCNFac=; b=mAIbvnSbSujXriDone/jjS4I6hRdXbCA6Sb+MUaRuNWkIv0C+UTJskIZwnosB21vDQ GM5uBqOYGmjZmzBvzcWO3BRwgYvDA47BfeHSLZnpiQTPE8wlGEXSrIfXPI+cTZjNueI2 ac8/+2ZXhvKnXpb3IYUEHaoCIdg3h+8EuvdfE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749145985; x=1749750785; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IAddCa1zo14U93p/hxz3tXNuMoufL4dFoj1aELCNFac=; b=oYIbGhfb/cOwF6BLC3t5X0aX5qdYodIQ5K5X6dAIfkq1w9IgkQNnr2HfI8MQYn7raT 1kiRyU0ZO4dBXNZLwlUh+1jtqHZTRnYdcAktjuETvJcS+IzKMFvwNTQcc+X3Dla04U2Q vy4cmKp6RiQjPxyqBRcdKDmDxuj1I7LGK8WZz9aZgmumYDRD1YfwWIXFMvxKd6/9IhlV S/YvVMQeE02IBdGHVXxrRvf3jYWs+uj2JMjv0O3GgejvcgymLC8T7RDhkIRtOmPasl3r 8X5VfVn69tnzmtr62LQdQPBOYJYki3dVd7b8TTcjNSMeOYhvQ2QLI/HOX5qEj2b7pts3 uTZg== X-Forwarded-Encrypted: i=1; AJvYcCVyf4vMhtIVMcSmdqp/firrVRzLQxD9JP0zShwGsAVfVp4JBSvwrq57Bp6LoUVz3ERkuaNeuZ3jMO4=@vger.kernel.org X-Gm-Message-State: AOJu0YxQ0e1m0UR7zmD5DaJsx3RXdsGNI/b+eJxq16jhOaMJaNgYOqE5 Y2xyQfd8xHuI0wzW49PAygUj53QNLLKfgfOHriDVCVCyqvgW8thhBaQlAP/VVrBvZw== X-Gm-Gg: ASbGncs4ITceO4WuDJOBzsueekOYHrudEBe9pGL6RMTlXphZ/sz/x4VzOvP0UIoEx1x ILFCwI6N62zNckOlzHFT7yCXpDZ+Ooa0QSyWY8Q7Sh0iW87ramajVAh+F0x/Zj26+qIz8vd28z2 421aOGwfnLBEWjje68cp/JjKwGOr79LqvSE/LyfAjvAgsHDwDFmfLTDxM5EVquS+/xM8WXn2Cb4 0yraBrQH899upLzYhDV/l6LLREsnSw9xXWBvP5bb+e0vgc26lOuN/LfhiynuKVB/czj7Wk/wNZc ORhzo+9Kk5Z8mthVDy5zbUJObOYtT74ib9dcc5CUaF6RBVDeXCs3R/lN5XY93WEYW9dWKUWtA4d FCanfyLBsDHLZFvW3ImC7xstUOw== X-Google-Smtp-Source: AGHT+IEuQ3DoWfSTvrnWbXmxFE5uIRwAzd3dzxpPZvGceJdrS5ZQ7/hUcchLBDj/wBd6vU9oMBKPzQ== X-Received: by 2002:a05:6512:3e0f:b0:553:30fc:cedf with SMTP id 2adb3069b0e04-55366c1ee9emr20515e87.38.1749145984851; Thu, 05 Jun 2025 10:53:04 -0700 (PDT) Received: from ribalda.c.googlers.com (90.52.88.34.bc.googleusercontent.com. [34.88.52.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553379379c2sm2641210e87.251.2025.06.05.10.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jun 2025 10:53:04 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 05 Jun 2025 17:52:57 +0000 Subject: [PATCH v2 04/12] media: ipu-bridge: Use v4l2_fwnode_device_parse helper Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250605-uvc-orientation-v2-4-5710f9d030aa@chromium.org> References: <20250605-uvc-orientation-v2-0-5710f9d030aa@chromium.org> In-Reply-To: <20250605-uvc-orientation-v2-0-5710f9d030aa@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , "Rafael J. Wysocki" , Len Brown Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 v4l2_fwnode_device_parse now supports acpi devices as well. Use the helper instead of re-implement the logic. Signed-off-by: Ricardo Ribalda --- drivers/media/pci/intel/ipu-bridge.c | 32 ++++++-------------------------- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c index 83e682e1a4b77d9d97b2988750732d0b7c9087b3..020aa52f590d66b6d333adc56ebfb9ab0561db51 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -253,36 +253,16 @@ static u32 ipu_bridge_parse_rotation(struct acpi_device *adev, static enum v4l2_fwnode_orientation ipu_bridge_parse_orientation(struct acpi_device *adev) { - enum v4l2_fwnode_orientation orientation; - struct acpi_pld_info *pld = NULL; + struct v4l2_fwnode_device_properties props; + int ret; - if (!acpi_get_physical_device_location(ACPI_PTR(adev->handle), &pld)) { - dev_warn(ADEV_DEV(adev), "_PLD call failed, using default orientation\n"); + ret = v4l2_fwnode_device_parse(ADEV_DEV(adev), &props); + if (!ret || props.rotation == V4L2_FWNODE_PROPERTY_UNSET) { + dev_warn(ADEV_DEV(adev), "Using default orientation\n"); return V4L2_FWNODE_ORIENTATION_EXTERNAL; } - switch (pld->panel) { - case ACPI_PLD_PANEL_FRONT: - orientation = V4L2_FWNODE_ORIENTATION_FRONT; - break; - case ACPI_PLD_PANEL_BACK: - orientation = V4L2_FWNODE_ORIENTATION_BACK; - break; - case ACPI_PLD_PANEL_TOP: - case ACPI_PLD_PANEL_LEFT: - case ACPI_PLD_PANEL_RIGHT: - case ACPI_PLD_PANEL_UNKNOWN: - orientation = V4L2_FWNODE_ORIENTATION_EXTERNAL; - break; - default: - dev_warn(ADEV_DEV(adev), "Unknown _PLD panel val %d\n", - pld->panel); - orientation = V4L2_FWNODE_ORIENTATION_EXTERNAL; - break; - } - - ACPI_FREE(pld); - return orientation; + return props.orientation; } int ipu_bridge_parse_ssdb(struct acpi_device *adev, struct ipu_sensor *sensor) -- 2.50.0.rc0.642.g800a2b2222-goog