public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: RD Babiera <rdbabiera@google.com>
Cc: heikki.krogerus@linux.intel.com, badhri@google.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: altmodes/displayport: add irq_hpd to sysfs
Date: Thu, 19 Jun 2025 06:32:41 +0200	[thread overview]
Message-ID: <2025061924-eats-john-8554@gregkh> (raw)
In-Reply-To: <20250619000343.3299526-2-rdbabiera@google.com>

On Thu, Jun 19, 2025 at 12:03:40AM +0000, RD Babiera wrote:
> @@ -170,6 +178,9 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
>  				dp->hpd = hpd;
>  				dp->pending_hpd = true;
>  			}
> +			if (dp->hpd && dp->pending_hpd && irq_hpd) {
> +				dp->pending_irq_hpd = true;
> +			}

Didn't checkpatch complain about not needing the {} here?

thanks,

greg k-h

  reply	other threads:[~2025-06-19  4:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19  0:03 [PATCH v1] usb: typec: altmodes/displayport: add irq_hpd to sysfs RD Babiera
2025-06-19  4:32 ` Greg KH [this message]
2025-06-23 20:28   ` RD Babiera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025061924-eats-john-8554@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=badhri@google.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rdbabiera@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox