From: Greg KH <gregkh@linuxfoundation.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Zongmin Zhou <min_halo@163.com>,
shuah@kernel.org, valentina.manea.m@gmail.com, i@zenithal.me,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
zhouzongmin@kylinos.cn
Subject: Re: [PATCH v2] usbip: convert to use faux_device
Date: Thu, 19 Jun 2025 13:02:17 +0200 [thread overview]
Message-ID: <2025061955-pungent-overripe-f8e4@gregkh> (raw)
In-Reply-To: <1a9cea94-c198-4cc4-bd69-d36f6511a121@linuxfoundation.org>
On Tue, Jun 10, 2025 at 09:15:51AM -0600, Shuah Khan wrote:
> On 6/4/25 00:54, Zongmin Zhou wrote:
> > From: Zongmin Zhou <zhouzongmin@kylinos.cn>
> >
> > The vhci driver does not need to create a platform device,
> > it only did so because it was simple to do that in order to
> > get a place in sysfs to hang some device-specific attributes.
> > Now the faux device interface is more appropriate,change it
> > over to use the faux bus instead.
> >
> > Signed-off-by: Zongmin Zhou <zhouzongmin@kylinos.cn>
> > ---
> > Changes in v2:
> > - don't change faux create api,just call probe on vhci_hcd_init.
>
> I will defer the review to Greg on this.
>
> I am fine with the change if Greg is happy with it. :)
Well the build errors aren't that good, but overall, yes, it's a nice
change :)
thanks,
greg k-h
next prev parent reply other threads:[~2025-06-19 11:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 9:11 [PATCH 0/2] some changes based on faux bus Zongmin Zhou
2025-05-08 9:11 ` [PATCH 1/2] driver core:add device's platform_data set for faux device Zongmin Zhou
2025-05-08 9:45 ` Greg KH
2025-05-09 2:41 ` Zongmin Zhou
2025-05-21 10:51 ` Greg KH
2025-05-28 9:21 ` Zongmin Zhou
2025-05-08 9:11 ` [PATCH 2/2] usbip: convert to use faux_device Zongmin Zhou
2025-05-09 10:42 ` kernel test robot
2025-06-04 6:54 ` [PATCH v2] " Zongmin Zhou
2025-06-10 15:15 ` Shuah Khan
2025-06-19 11:02 ` Greg KH [this message]
2025-06-19 11:01 ` Greg KH
2025-06-20 2:16 ` Zongmin Zhou
2025-06-20 4:29 ` Greg KH
2025-06-20 9:19 ` Zongmin Zhou
2025-06-20 9:27 ` Greg KH
2025-06-20 17:26 ` Shuah Khan
2025-06-24 3:21 ` Zongmin Zhou
2025-07-01 22:56 ` Shuah Khan
2025-07-02 2:12 ` Zongmin Zhou
2025-07-02 23:54 ` Shuah Khan
2025-07-03 6:04 ` Zongmin Zhou
2025-07-08 18:16 ` Shuah Khan
2025-07-09 9:07 ` Zongmin Zhou
2025-07-09 10:06 ` Greg KH
2025-07-09 14:20 ` Alan Stern
2025-07-09 21:49 ` Shuah Khan
2025-07-09 21:57 ` Shuah Khan
2025-07-10 14:06 ` Alan Stern
2025-07-10 20:33 ` Shuah Khan
2025-07-11 5:56 ` Greg KH
2025-07-14 5:31 ` Zongmin Zhou
2025-07-09 21:33 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025061955-pungent-overripe-f8e4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=min_halo@163.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=valentina.manea.m@gmail.com \
--cc=zhouzongmin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox