public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: zhangjianrong <zhangjianrong5@huawei.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
	mika.westerberg@linux.intel.com, YehezkelShB@gmail.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	guhengsheng@hisilicon.com, caiyadong@huawei.com,
	xuetao09@huawei.com, lixinghang1@huawei.com
Subject: Re: [PATCH v2] thunderbolt: Check whether bandwidth request needs asymmetric mode before check whether it can be done
Date: Sat, 28 Jun 2025 15:50:10 +0200	[thread overview]
Message-ID: <2025062837-stability-unmoved-42e8@gregkh> (raw)
In-Reply-To: <20250628123453.770988-1-zhangjianrong5@huawei.com>

On Sat, Jun 28, 2025 at 08:34:53PM +0800, zhangjianrong wrote:
> Current implementation may cause allocation failures in
> tb_alloc_dp_bandwidth() in some cases. This will happen
> when requesting downstream bandwidth while total upstream
> bandwidth usage on the link exceeds TB_ASYM_MIN (36 Gbps).
> tb_configure_asym() will return -ENOBUFS while asymmetric
> mode isn't necessary.
> 
> Fixes: 3e36528c1127 ("thunderbolt: Configure asymmetric link if needed and bandwidth allows")
> Signed-off-by: zhangjianrong <zhangjianrong5@huawei.com>


Please use a real name, not an email alias, for a signed-off-by line.

Also, if this fixes old bugs, why did you not also include a cc:
stable@kernel.org line?

thanks,

greg k-h

      reply	other threads:[~2025-06-28 13:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-28 12:34 [PATCH v2] thunderbolt: Check whether bandwidth request needs asymmetric mode before check whether it can be done zhangjianrong
2025-06-28 13:50 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025062837-stability-unmoved-42e8@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=caiyadong@huawei.com \
    --cc=guhengsheng@hisilicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lixinghang1@huawei.com \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=xuetao09@huawei.com \
    --cc=zhangjianrong5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox