From: Seungjin Bae <eeodqql09@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: pip-izony <eeodqql09@gmail.com>,
"Kyungtae Kim" <Kyungtae.Kim@dartmouth.edu>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: gadget: m66592-udc: Ignore feature requests for EP0
Date: Sat, 28 Jun 2025 22:59:53 -0400 [thread overview]
Message-ID: <20250629025951.17581-3-eeodqql09@gmail.com> (raw)
The `set_feature() and clear_feature() functions handle requests to set or clear the ENDPOINT_HALT feature.
Currently, these requests are processed for any endpoint, including the control endpoint (EP0).
The ENDPOINT_HALT feature is not defined for control endpoints according to the USB specification 9.4.5.
Fixes: 4cf2503c6801a ("USB: m66592-udc: peripheral controller driver for M66592")
Co-developed-by: Kyungtae Kim <Kyungtae.Kim@dartmouth.edu>
Signed-off-by: Kyungtae Kim <Kyungtae.Kim@dartmouth.edu>
Signed-off-by: Seungjin Bae <eeodqql09@gmail.com>
---
drivers/usb/gadget/udc/m66592-udc.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c
index 715791737499..38cc11ae80b6 100644
--- a/drivers/usb/gadget/udc/m66592-udc.c
+++ b/drivers/usb/gadget/udc/m66592-udc.c
@@ -1010,8 +1010,13 @@ static void clear_feature(struct m66592 *m66592, struct usb_ctrlrequest *ctrl)
struct m66592_ep *ep;
struct m66592_request *req;
u16 w_index = le16_to_cpu(ctrl->wIndex);
+ u16 ep_num = w_index & USB_ENDPOINT_NUMBER_MASK;
- ep = m66592->epaddr2ep[w_index & USB_ENDPOINT_NUMBER_MASK];
+ if (ep_num == 0) {
+ control_end(m66592, 1);
+ break;
+ }
+ ep = m66592->epaddr2ep[ep_num];
pipe_stop(m66592, ep->pipenum);
control_reg_sqclr(m66592, ep->pipenum);
@@ -1067,8 +1072,13 @@ static void set_feature(struct m66592 *m66592, struct usb_ctrlrequest *ctrl)
case USB_RECIP_ENDPOINT: {
struct m66592_ep *ep;
u16 w_index = le16_to_cpu(ctrl->wIndex);
+ u16 ep_num = w_index & USB_ENDPOINT_NUMBER_MASK;
- ep = m66592->epaddr2ep[w_index & USB_ENDPOINT_NUMBER_MASK];
+ if (ep_num == 0) {
+ control_end(m66592, 1);
+ break;
+ }
+ ep = m66592->epaddr2ep[ep_num];
pipe_stall(m66592, ep->pipenum);
control_end(m66592, 1);
--
2.43.0
next reply other threads:[~2025-06-29 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 2:59 Seungjin Bae [this message]
2025-06-29 6:10 ` [PATCH] usb: gadget: m66592-udc: Ignore feature requests for EP0 Greg Kroah-Hartman
2025-06-29 13:33 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250629025951.17581-3-eeodqql09@gmail.com \
--to=eeodqql09@gmail.com \
--cc=Kyungtae.Kim@dartmouth.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox