From: "Peter Chen (CIX)" <peter.chen@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Chen Ni <nichen@iscas.ac.cn>,
Xu Yang <xu.yang_2@nxp.com>
Subject: Re: [PATCH] usb: chipidea: udc: Use usb_endpoint_is_isoc_in() rather than duplicating its implementation
Date: Mon, 30 Jun 2025 19:39:37 +0800 [thread overview]
Message-ID: <20250630113937.GA222582@nchen-desktop> (raw)
In-Reply-To: <e9b363cb-1223-41fa-8613-73ff9a1d4a30@web.de>
On 25-06-24 17:40:17, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 24 Jun 2025 17:30:52 +0200
>
> Reuse existing functionality from usb_endpoint_is_isoc_in() instead of
> keeping duplicate source code.
>
> The source code was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Peter Chen <peter.chen@kernel.org>
Peter
> ---
> drivers/usb/chipidea/udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 64a421ae0f05..75705089136c 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1992,7 +1992,7 @@ static struct usb_ep *ci_udc_match_ep(struct usb_gadget *gadget,
> struct ci_hdrc *ci = container_of(gadget, struct ci_hdrc, gadget);
> struct usb_ep *ep;
>
> - if (usb_endpoint_xfer_isoc(desc) && usb_endpoint_dir_in(desc)) {
> + if (usb_endpoint_is_isoc_in(desc)) {
> list_for_each_entry_reverse(ep, &ci->gadget.ep_list, ep_list) {
> if (ep->caps.dir_in && !ep->claimed)
> return ep;
> --
> 2.50.0
>
--
Best regards,
Peter
prev parent reply other threads:[~2025-06-30 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 15:40 [PATCH] usb: chipidea: udc: Use usb_endpoint_is_isoc_in() rather than duplicating its implementation Markus Elfring
2025-06-25 2:13 ` Xu Yang
2025-06-30 11:39 ` Peter Chen (CIX) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630113937.GA222582@nchen-desktop \
--to=peter.chen@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox