From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7637C28AB03 for ; Mon, 30 Jun 2025 13:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751290598; cv=none; b=EGCW2E4nhwKbJnRuVGHC0PCx4W3Tx8De1E8adX8pG9wrtVjxsd/dLznqFqrTrjvbIgd0Dw7U35QiF5VWiAoeXbPTEs433MU06BbJpymf0mx9zn5Z/qos3aZB7/KVFpXOnROeTJ20OaI9nTriTpZMf5yR03N08oG061JFhdUOXWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751290598; c=relaxed/simple; bh=Es0BAWbLQibUKYTKDfhgk3aIMdGXzA2xZxm7+MQRgNs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ze/MK8S387HNuRCGij7YJ7l+Kw6irm/QPEBiu2kkpMsoaTWLCzX3FcPOKuR6TZOFxGqky1tnoEL/7zpOTFoCR8x3ei73W5ZO8AzU1RvnHIDweB8HC9ms4S9AXYgKTNvCrntlpYOFOsAqCjOwYg8zrEYd4h8PydaK7185vKHRM0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=L55hf66U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="L55hf66U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D444C4CEE3; Mon, 30 Jun 2025 13:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751290597; bh=Es0BAWbLQibUKYTKDfhgk3aIMdGXzA2xZxm7+MQRgNs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L55hf66UooVYYlNq2P2OYFKx/PBOCdvMrMoGMiUBy630RlC2M7tlewEeJrms8p7tu iuvGLtmNOUPyVdsGAJZSTJy3f6Fv/QgIbAoD5+AyIbXmbPSwfnCbtrbDqzyeqSqPWe w9Zbvj6jW3OPjCdpq0KUpZ1/lHvarkGVx6+XE/9E= Date: Mon, 30 Jun 2025 15:36:34 +0200 From: Greg KH To: Mathias Nyman Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu, oneukum@suse.com, konrad.dybcio@oss.qualcomm.com, broonie@kernel.org, stable@kernel.org Subject: Re: [RFT PATCH v3 1/1] usb: hub: Fix flushing of delayed work used for post resume purposes Message-ID: <2025063021-slighting-fossil-a17e@gregkh> References: <20250627164348.3982628-1-mathias.nyman@linux.intel.com> <20250627164348.3982628-2-mathias.nyman@linux.intel.com> <2025062810-slush-trillion-b199@gregkh> <2025063001-angled-caretaker-4494@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 30, 2025 at 04:15:15PM +0300, Mathias Nyman wrote: > On 30.6.2025 14.19, Greg KH wrote: > > On Mon, Jun 30, 2025 at 01:07:29PM +0300, Mathias Nyman wrote: > > > On 28.6.2025 17.46, Greg KH wrote: > > > > On Fri, Jun 27, 2025 at 07:43:48PM +0300, Mathias Nyman wrote: > > > > > Delayed work that prevents USB3 hubs from runtime-suspending too early > > > > > needed to be flushed in hub_quiesce() to resolve issues detected on > > > > > QC SC8280XP CRD board during suspend resume testing. > > > > > > > > > > This flushing did however trigger new issues on Raspberry Pi 3B+, which > > > > > doesn't have USB3 ports, and doesn't queue any post resume delayed work. > > > > > > > > > > The flushed 'hub->init_work' item is used for several purposes, and > > > > > is originally initialized with a 'NULL' work function. The work function > > > > > is also changed on the fly, which may contribute to the issue. > > > > > > > > > > Solve this by creating a dedicated delayed work item for post resume work, > > > > > and flush that delayed work in hub_quiesce() > > > > > > > > > > Cc: stable@kernel.org > > > > > Fixes: a49e1e2e785f ("usb: hub: Fix flushing and scheduling of delayed work that tunes runtime pm") > > > > > Reported-by: Mark Brown > > > > > Closes: https://lore.kernel.org/linux-usb/aF5rNp1l0LWITnEB@finisterre.sirena.org.uk > > > > > Signed-off-by: Mathias Nyman > > > > > --- > > > > > v3: > > > > > - Rebase on top of a49e1e2e785f ("usb: hub: Fix flushing and scheduling of delayed work that tunes runtime pm") > > > > > - Rewrite commit message > > > > > > > > > > v2: > > > > > - Add and use dedicated delayed work struct for post resume work > > > > > - Add commit message section about dedicated work > > > > > > > > This seems to work, want me to take this, or are you going to submit > > > > another one? I'll hold off on sending the pull request to Linus for > > > > -rc4 because of this. > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Sorry about the response delay, was offline during weekend > > > > As one should be! :) > > > > > I'll do some quick additional smoketests, suspending and disconnecting runtime suspended > > > chained USB3 hubs. Shouldn't take more than a couple of hours > > > > Ok, no rush, thanks for letting me know. > > > > My additional smoktests passed as well. > > Can you pick this RFT PATCH v3 as it is? > Or want a new one with all those "Tested-by" tags I took it as-is, b4 grabbed the tested-by flags just fine. thanks! greg k-h