From: Jakub Kicinski <kuba@kernel.org>
To: "Peter GJ. Park" <gyujoon.park@samsung.com>
Cc: pabeni@redhat.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
oneukum@suse.com
Subject: Re: [PATCH net v2] net: usb: usbnet: fix use-after-free in race on workqueue
Date: Tue, 1 Jul 2025 18:27:22 -0700 [thread overview]
Message-ID: <20250701182722.1a932ed6@kernel.org> (raw)
In-Reply-To: <20250627105953.2711808-1-gyujoon.park@samsung.com>
On Fri, 27 Jun 2025 19:59:53 +0900 Peter GJ. Park wrote:
> When usbnet_disconnect() queued while usbnet_probe() processing,
> it results to free_netdev before kevent gets to run on workqueue,
> thus workqueue does assign_work() with referencing freeed memory address.
>
> For graceful disconnect and to prevent use-after-free of netdev pointer,
> the fix adds canceling work and timer those are placed by usbnet_probe()
Discussion on the v1 thread is ongoing, please repost once it concludes.
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-02 1:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250625093354epcas1p1c9817df6e1d1599e8b4eb16c5715a6fd@epcas1p1.samsung.com>
2025-06-25 9:33 ` [PATCH] net: usb: usbnet: fix use-after-free in race on workqueue Peter GJ. Park
2025-06-26 9:21 ` Paolo Abeni
2025-06-27 10:47 ` [PATCH v2] " Peter GJ. Park
2025-06-27 10:59 ` [PATCH net " Peter GJ. Park
2025-07-02 1:27 ` Jakub Kicinski [this message]
2025-07-01 4:19 ` [PATCH net] " Peter GJ. Park
2025-07-01 13:22 ` [PATCH] " Oliver Neukum
2025-07-02 1:26 ` Jakub Kicinski
2025-07-02 10:54 ` Oliver Neukum
2025-07-02 18:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701182722.1a932ed6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gyujoon.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox