From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Ryan Mann <rmann@ndigital.com>
Cc: "johan@kernel.org" <johan@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NDI FTDI USB driver support
Date: Fri, 4 Jul 2025 18:16:23 +0200 [thread overview]
Message-ID: <2025070427-pebble-stir-d4b0@gregkh> (raw)
In-Reply-To: <YQXPR01MB49879486E5B552D1B0A0E5F6DF42A@YQXPR01MB4987.CANPRD01.PROD.OUTLOOK.COM>
On Fri, Jul 04, 2025 at 02:44:46PM +0000, Ryan Mann wrote:
> NDI (Northern Digital Inc.) is introducing a new product called the EMGUIDE GEMINI that will use an FTDI chip for USB serial communications. The EMGUIDE GEMINI will support 1.2Mbaud the same as other NDI FTDI USB serial devices, by mapping the 19200. It was noticed in making this change that the NDI Aurora was included in this "quirk", but it does not support rates as high as 1.2Mbaud, so it was replaced by the EMGUIDE.
> This patch adds the new VID as "FTDI_NDI_VID" in the ftdi_sio_ids.h header file. It also reserves PID 0x0003 for the EMGUIDE GEMINI. Finally, it adds this VID/PID combination to the USB_DEVICE list in the ftdi_sio.c.
Please take the time, read the documentation, and then resend new
versions :)
You forgot to wrap your lines here.
And you forgot to version your patch.
And you included the old version of the patch below this patch, making
it impossible to apply.
Take the weekend, relax, and come back with a version 3 of this next
week. There's no rush here.
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-04 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 19:51 [PATCH] NDI FTDI USB driver support Ryan Mann
2025-07-04 5:18 ` gregkh
2025-07-04 14:44 ` Ryan Mann
2025-07-04 16:16 ` gregkh [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-07-03 18:53 Ryan Mann
2025-07-03 19:08 ` gregkh
2025-07-03 18:51 Ryan Mann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025070427-pebble-stir-d4b0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rmann@ndigital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox