public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jie Deng <dengjie03@kylinos.cn>
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH v2] usb: storage: Ignore UAS driver for SanDisk Extreme Pro 55AF storage device
Date: Tue, 8 Jul 2025 09:32:07 +0200	[thread overview]
Message-ID: <2025070830-edge-deprive-ce6b@gregkh> (raw)
In-Reply-To: <2c4af4f8-5763-4ebf-8070-c7eabf43fe5e@kylinos.cn>

On Mon, Jul 07, 2025 at 05:52:31PM +0800, Jie Deng wrote:
> 
> 在 2025/7/7 16:47, Greg KH 写道:
> >    > So ignore UAS driver for this device.
> > > > Signed-off-by: Jie Deng <dengjie03@kylinos.cn>
> > > ---
> > > v2:
> > > 	* According to the file modification rules (sort by VendorID > 	
> > first, then by ProductID.) Add the newly added "UNUSUAL_DEV" > 	  in the
> > correct position.
> > > v1:
> > > 	* The newly added "UNUSUAL_DEV" was directly added to the end > 	
> > without modifying the format according to the file.
> > > > ---
> > >  drivers/usb/storage/unusual_uas.h | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > > diff --git a/drivers/usb/storage/unusual_uas.h
> > b/drivers/usb/storage/unusual_uas.h
> > > index 1477e31d7763..6b1a08e2e724 100644
> > > --- a/drivers/usb/storage/unusual_uas.h
> > > +++ b/drivers/usb/storage/unusual_uas.h
> > > @@ -52,6 +52,13 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
> > >  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> > >  		US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
> > >  > +/* Reported-by: Jie Deng <dengjie03@kylinos.cn> */
> > > +UNUSUAL_DEV(0x0781, 0x55af, 0x0000, 0x9999,
> > > +		"SanDisk",
> > > +		"Extreme Pro 55AF",
> > > +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> > > +		US_FL_IGNORE_UAS),
> > > +
> > >  /* Reported-by: Zhihong Zhou <zhouzhihong@greatwall.com.cn> */
> > >  UNUSUAL_DEV(0x0781, 0x55e8, 0x0000, 0x9999,
> > >  		"SanDisk",
> > > -- > 2.25.1
> > 
> > Why is there two "v2" patches sent here?  Shouldn't this be "v3"?
> > 
> > confused,
> > 
> > greg k-h                     
> > 
> The first sent V2 patch was missing the description of the
> differences between V1 and V2 patches. The V2 patch sent for
> the second time only adds a description of the differences
> from the V1 patch compared to the V2 patch sent for the first time.
> There is no modification to the code. So it is rashly believed
> that it does not need to be defined as a V3 patch.
> 

Think about what you would do if you got sent 2 "v2" patches?  :)

Remember, some of us get hundreds/thousands of emails to handle a day,
please make it very obvious what to do here.

thanks,

greg k-h

  reply	other threads:[~2025-07-08  7:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  9:29 [PATCH] usb: storage: Ignore UAS driver for SanDisk Extreme Pro 55AF storage device Jie Deng
2025-07-03 10:01 ` Greg KH
2025-07-04  6:11   ` [PATCH v2] " Jie Deng
2025-07-04  8:24     ` Greg KH
2025-07-07  6:25       ` Jie Deng
2025-07-07  8:47         ` Greg KH
2025-07-07  9:52           ` Jie Deng
2025-07-08  7:32             ` Greg KH [this message]
2025-07-09  3:13               ` Jie Deng
2025-07-07  8:49         ` Greg KH
2025-07-08  5:55           ` Jie Deng
2025-07-08  7:33             ` Greg KH
     [not found]               ` <92f1e73f-5814-4e01-98b6-1c9c0b87f903@kylinos.cn>
2025-07-09  6:21                 ` Greg KH
2025-07-10  6:28                   ` Jie Deng
2025-07-04  7:39   ` [PATCH] " Jie Deng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025070830-edge-deprive-ce6b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dengjie03@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox