linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
	Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
	"Brian G. Merrell" <bgmerrell@novell.com>,
	kernel@collabora.com, Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] usb: vhci-hcd: Fix block comments
Date: Thu, 17 Jul 2025 18:19:05 +0200	[thread overview]
Message-ID: <2025071751-whomever-colt-14b4@gregkh> (raw)
In-Reply-To: <20250717-vhci-hcd-suspend-fix-v1-6-2b000cd05952@collabora.com>

On Thu, Jul 17, 2025 at 06:54:55PM +0300, Cristian Ciocaltea wrote:
> Address a couple of comment formatting issues indicated by
> checkpatch.pl:
> 
>   WARNING: Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  drivers/usb/usbip/vhci_hcd.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 53691d5e77d386b0b0e16fe9d08824baa04c0b1e..a2a8418c77e58ae9e06d673d0012b972c92ee33b 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -879,7 +879,8 @@ static int vhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int status)
>  	priv = urb->hcpriv;
>  	if (!priv) {
>  		/* URB was never linked! or will be soon given back by
> -		 * vhci_rx. */
> +		 * vhci_rx.
> +		 */

The comment should just be one line long.

>  		spin_unlock_irqrestore(&vhci->lock, flags);
>  		return -EIDRM;
>  	}
> @@ -936,7 +937,8 @@ static int vhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int status)
>  		unlink->unlink_seqnum = priv->seqnum;
>  
>  		/* send cmd_unlink and try to cancel the pending URB in the
> -		 * peer */
> +		 * peer
> +		 */

Same here.

thanks,

greg k-h

  reply	other threads:[~2025-07-17 16:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17 15:54 [PATCH 0/9] USB/IP VHCI suspend fix and driver cleanup Cristian Ciocaltea
2025-07-17 15:54 ` [PATCH 1/9] usb: vhci-hcd: Prevent suspending virtually attached devices Cristian Ciocaltea
2025-07-17 18:26   ` Alan Stern
2025-07-17 19:55     ` Shuah Khan
2025-07-18  6:41       ` Cristian Ciocaltea
2025-07-25 10:20         ` Cristian Ciocaltea
2025-07-17 15:54 ` [PATCH 2/9] usb: vhci-hcd: Fix space, brace, alignment and line length issues Cristian Ciocaltea
2025-07-17 16:18   ` Greg Kroah-Hartman
2025-07-17 17:26     ` Cristian Ciocaltea
2025-07-18  6:26       ` Greg Kroah-Hartman
2025-07-18  6:48         ` Cristian Ciocaltea
2025-07-17 15:54 ` [PATCH 3/9] usb: vhci-hcd: Simplify NULL comparison Cristian Ciocaltea
2025-07-17 15:54 ` [PATCH 4/9] usb: vhci-hcd: Simplify kzalloc usage Cristian Ciocaltea
2025-07-17 15:54 ` [PATCH 5/9] usb: vhci-hcd: Do not split quoted strings Cristian Ciocaltea
2025-07-17 16:19   ` Greg Kroah-Hartman
2025-07-17 17:35     ` Cristian Ciocaltea
2025-07-17 15:54 ` [PATCH 6/9] usb: vhci-hcd: Fix block comments Cristian Ciocaltea
2025-07-17 16:19   ` Greg Kroah-Hartman [this message]
2025-07-17 15:54 ` [PATCH 7/9] usb: vhci-hcd: Use the paranthesized form of sizeof Cristian Ciocaltea
2025-07-17 15:54 ` [PATCH 8/9] usb: vhci-hcd: Consistently use __func__ Cristian Ciocaltea
2025-07-17 16:18   ` Greg Kroah-Hartman
2025-07-17 17:43     ` Cristian Ciocaltea
2025-07-17 15:54 ` [PATCH 9/9] usb: vhci-hcd: Remove ftrace-like logging Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025071751-whomever-colt-14b4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bgmerrell@novell.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=gregkh@suse.de \
    --cc=i@zenithal.me \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).