public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Tao Xue <xuetao09@huawei.com>
To: <gregkh@linuxfoundation.org>, <Thinh.Nguyen@synopsys.com>,
	<prashanth.k@oss.qualcomm.com>, <m.grzeschik@pengutronix.de>,
	<Chris.Wulff@biamp.com>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <caiyadong@huawei.com>, <suzhuangluan@hisilicon.com>,
	<weiwenwen3@huawei.com>
Subject: [PATCH] usb: gadget : fix use-after-free in composite_dev_cleanup()
Date: Sat, 19 Jul 2025 12:56:12 +0800	[thread overview]
Message-ID: <20250719045612.10739-1-xuetao09@huawei.com> (raw)

The pointer cdev->os_desc_req need to be set null when kmalloc failed in
composite_os_desc_req_prepare(),otherwise the use-after-free issue will
be encountered in composite_dev_cleanup()

BUG: KASAN: use-after-free in composite_dev_cleanup+0xf4/0x2c0
Read of size 8 at addr 0000004827837a00 by task init/1

CPU: 10 PID: 1 Comm: init Tainted: G           O      5.10.97-oh #1
 kasan_report+0x188/0x1cc
 __asan_load8+0xb4/0xbc
 composite_dev_cleanup+0xf4/0x2c0
 configfs_composite_bind+0x210/0x7ac
 udc_bind_to_driver+0xb4/0x1ec
 usb_gadget_probe_driver+0xec/0x21c
 gadget_dev_desc_UDC_store+0x264/0x27c

Fixes: 37a3a533429e ("usb: gadget: OS Feature Descriptors support")
Signed-off-by: Tao Xue <xuetao09@huawei.com>
Signed-off-by: weiwenwen <weiwenwen3@huawei.com>
---
 drivers/usb/gadget/composite.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 8dbc132a505e..385398a039ea 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -2489,6 +2489,7 @@ int composite_os_desc_req_prepare(struct usb_composite_dev *cdev,
 	if (!cdev->os_desc_req->buf) {
 		ret = -ENOMEM;
 		usb_ep_free_request(ep0, cdev->os_desc_req);
+		cdev->os_desc_req = NULL;
 		goto end;
 	}
 	cdev->os_desc_req->context = cdev;
-- 
2.17.1


             reply	other threads:[~2025-07-19  4:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-19  4:56 Tao Xue [this message]
2025-07-19  6:56 ` [PATCH] usb: gadget : fix use-after-free in composite_dev_cleanup() Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250719045612.10739-1-xuetao09@huawei.com \
    --to=xuetao09@huawei.com \
    --cc=Chris.Wulff@biamp.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=caiyadong@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=prashanth.k@oss.qualcomm.com \
    --cc=suzhuangluan@hisilicon.com \
    --cc=weiwenwen3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox