Re: [PATCH v2] usb: typec: ucsi: Add support for READ_POWER_LEVEL command

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Jul 03, 2025 at 12:32:59PM -0700, Venkat Jayaraman wrote:
> Add support for UCSI READ_POWER_LEVEL command as per
> UCSI specification v2.1 and above to debugfs.
> 
> Following power related fields will be exposed as files in debugfs:-
> peak_current (Peak current),
> avg_current (Average current) and
> vbus_voltage (VBUS voltage)
> 
> These files will be updated either when a READ_POWER_LEVEL
> command is sent from OS or when a device is connected.
> 
> Signed-off-by: Venkat Jayaraman <venkat.jayaraman@intel.com>
> ---
> Changelog v2:
> - Removed extra space in declaration
> - Made the call to debugfs_create_file single line for clarity
> 
>  drivers/usb/typec/ucsi/debugfs.c | 31 +++++++++++++++++++++++++++++++
>  drivers/usb/typec/ucsi/ucsi.c    | 16 ++++++++++++++++
>  drivers/usb/typec/ucsi/ucsi.h    | 13 +++++++++++++
>  3 files changed, 60 insertions(+)

You somehow did not cc: the proper maintainers on this at all, have you
gone through the proper Intel kernel developer training that should
document all of this type of thing?  If not, please do so.

thanks,

greg k-h