* [PATCH] thunderbolt: Fix copy+paste error in match_service_id()
@ 2025-07-21 5:01 Eric Biggers
2025-07-21 14:33 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2025-07-21 5:01 UTC (permalink / raw)
To: Andreas Noever, Michael Jamet, Mika Westerberg, Yehezkel Bernat,
linux-usb
Cc: Eric Biggers
The second instance of TBSVC_MATCH_PROTOCOL_VERSION seems to have been
intended to be TBSVC_MATCH_PROTOCOL_REVISION.
Fixes: d1ff70241a27 ("thunderbolt: Add support for XDomain discovery protocol")
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
drivers/thunderbolt/domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c
index a3a7c8059eeeb..45239703745e5 100644
--- a/drivers/thunderbolt/domain.c
+++ b/drivers/thunderbolt/domain.c
@@ -34,11 +34,11 @@ static bool match_service_id(const struct tb_service_id *id,
if (id->match_flags & TBSVC_MATCH_PROTOCOL_VERSION) {
if (id->protocol_version != svc->prtcvers)
return false;
}
- if (id->match_flags & TBSVC_MATCH_PROTOCOL_VERSION) {
+ if (id->match_flags & TBSVC_MATCH_PROTOCOL_REVISION) {
if (id->protocol_revision != svc->prtcrevs)
return false;
}
return true;
base-commit: 89be9a83ccf1f88522317ce02f854f30d6115c41
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] thunderbolt: Fix copy+paste error in match_service_id()
2025-07-21 5:01 [PATCH] thunderbolt: Fix copy+paste error in match_service_id() Eric Biggers
@ 2025-07-21 14:33 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-07-21 14:33 UTC (permalink / raw)
To: Eric Biggers
Cc: Andreas Noever, Michael Jamet, Mika Westerberg, Yehezkel Bernat,
linux-usb
On Sun, Jul 20, 2025 at 10:01:36PM -0700, Eric Biggers wrote:
> The second instance of TBSVC_MATCH_PROTOCOL_VERSION seems to have been
> intended to be TBSVC_MATCH_PROTOCOL_REVISION.
>
> Fixes: d1ff70241a27 ("thunderbolt: Add support for XDomain discovery protocol")
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> drivers/thunderbolt/domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c
> index a3a7c8059eeeb..45239703745e5 100644
> --- a/drivers/thunderbolt/domain.c
> +++ b/drivers/thunderbolt/domain.c
> @@ -34,11 +34,11 @@ static bool match_service_id(const struct tb_service_id *id,
> if (id->match_flags & TBSVC_MATCH_PROTOCOL_VERSION) {
> if (id->protocol_version != svc->prtcvers)
> return false;
> }
>
> - if (id->match_flags & TBSVC_MATCH_PROTOCOL_VERSION) {
> + if (id->match_flags & TBSVC_MATCH_PROTOCOL_REVISION) {
> if (id->protocol_revision != svc->prtcrevs)
> return false;
> }
>
> return true;
>
> base-commit: 89be9a83ccf1f88522317ce02f854f30d6115c41
> --
> 2.50.1
>
>
Thanks, I'll just queue this up now.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-21 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21 5:01 [PATCH] thunderbolt: Fix copy+paste error in match_service_id() Eric Biggers
2025-07-21 14:33 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).