From: Greg KH <gregkh@linuxfoundation.org>
To: Darshan Rathod <darshanrathod475@gmail.com>
Cc: m.grzeschik@pengutronix.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: gadget: uvc: avoid assignment in if conditions
Date: Wed, 30 Jul 2025 13:28:51 +0200 [thread overview]
Message-ID: <2025073009-headrest-italics-2430@gregkh> (raw)
In-Reply-To: <20250730090411.13044-1-darshanrathod475@gmail.com>
On Wed, Jul 30, 2025 at 09:04:11AM +0000, Darshan Rathod wrote:
> Refactored code to separate assignments from conditional checks.
That is not all you did here :(
Please don't work on coding style cleanups for code that you do not know
is allowed to take those types of changes. And especially as a "first
contribution", please work in a subsystem that this type of changes are
explicitly asked for, like drivers/staging/
Work there first, get experience in the kernel development workflow, and
then worry about other parts of the kernel. That saves maintainer time
and energy in reviewing changes that are not correct :(
hope this helps,
greg k-h
prev parent reply other threads:[~2025-07-30 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 9:04 [PATCH v2] usb: gadget: uvc: avoid assignment in if conditions Darshan Rathod
2025-07-30 11:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025073009-headrest-italics-2430@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=darshanrathod475@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox