Re: [PATCH] usb: gadget: f_ncm: Fix MAC assignment NCM ethernet

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Aug 14, 2025 at 09:46:09AM -0400, raub camaioni wrote:
> This fix is already present in f_ecm.c and was never propagated to f_ncm.c
> 
> When creating multiple NCM ethernet devices on a composite usb gadget device
> each MAC address on the HOST side will be identical.
> Having the same MAC on different network interfaces is bad.
> 
> This fix updates the MAC address inside the ncm_strings_defs global during the ncm_bind call.
> This ensures each device has a unique MAC.
> In f_ecm.c ecm_string_defs is updated in the same way.
> 
> The defunct MAC assignment in ncm_alloc has been removed.
> 
> Signed-off-by: raub camaioni <raubcameo@gmail.com>
> ---
>  drivers/usb/gadget/function/f_ncm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Was this sent twice?  Which one is right?

> 
> diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/function/f_ncm.c
> index 58b0dd575af3..3164e75caa3b 100644
> --- a/drivers/usb/gadget/function/f_ncm.c
> +++ b/drivers/usb/gadget/function/f_ncm.c
> @@ -1463,6 +1463,8 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f)
>  
>  	ncm_opts->bound = true;
>  
> +	ncm_string_defs[1].s = ecm->ethaddr;
> +	

Did you run checkpatch on this?  It should have given you an error here
:(

thanks,

greg k-h