Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Adrian Barnaś" <abarnas@google.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] drivers/usb/mon/mon_bin: Style fixes
Date: Mon, 18 Aug 2025 14:23:26 +0200	[thread overview]
Message-ID: <2025081811-taps-film-182d@gregkh> (raw)
In-Reply-To: <20250818121745.1160522-1-abarnas@google.com>

On Mon, Aug 18, 2025 at 12:17:45PM +0000, Adrian Barnaś wrote:
> Address various coding style issues reported by checkpatch.pl
> in drivers/usb/mon/mon_bin.c to improve adherence to kernel coding style.

Note, given the age of the USB code, there are many portions that do not
follow the "correct" coding style.  Same for many other kernel
subsystems.  It's generally not a good idea to attempt to clean them up
as it doesn't provide any real benefit, unless the subsystem maintainer
says it's ok.

Otherwise it's just a constant churn over time as new things get added
to checkpatch.pl.  If you want to work on coding style cleanups, please
do so in drivers/staging/ as that is explicitly where it is allowed to
do so.

thanks,

greg k-h

      parent reply	other threads:[~2025-08-18 12:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 12:17 [PATCH] drivers/usb/mon/mon_bin: Style fixes Adrian Barnaś
2025-08-18 12:22 ` Greg Kroah-Hartman
2025-08-18 12:23 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025081811-taps-film-182d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=abarnas@google.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox