Linux USB
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Richard Leitner <richard.leitner@linux.dev>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-usb@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: usb: usb251xb: support usage case without I2C control
Date: Fri, 22 Aug 2025 10:17:04 +0200	[thread overview]
Message-ID: <20250822-quantum-hungry-orca-e6c6cb@kuoka> (raw)
In-Reply-To: <20250820161743.23458-2-jszhang@kernel.org>

On Thu, Aug 21, 2025 at 12:17:41AM +0800, Jisheng Zhang wrote:
> Currently, the usb251xb assumes i2c control, and the corresponding
> dt node looks like the following:
> 
> i2c {
> 	usb-hub@2c {
> 		compatible = "microchip,usb2512b";
> 		reg = <0x2c>;
> 		reset-gpios = <&porta 8 GPIO_ACTIVE_LOW>;
> 	};
> };

Above is redundant, obvious from stagtement that USB can be a device on
I2C bus. Just keep it simple.

> 
> But from HW point of view, the hub supports usage case without any i2c
> control, I.E we only want the gpio controls, for example the following
> dt node:
> 
> usb-hub {
> 	compatible = "microchip,usb2512b";
> 	reset-gpios = <&porta 8 GPIO_ACTIVE_LOW>;
> };
> 
> Modify the dt-binding of usb2512b to support this usage case, and add
> usage example to the examples section.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  Documentation/devicetree/bindings/usb/usb251xb.yaml | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


  reply	other threads:[~2025-08-22  8:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20 16:17 [PATCH v3 0/3] usb: usb251xb: support usage case without I2C control Jisheng Zhang
2025-08-20 16:17 ` [PATCH v3 1/3] dt-bindings: " Jisheng Zhang
2025-08-22  8:17   ` Krzysztof Kozlowski [this message]
2025-08-20 16:17 ` [PATCH v3 2/3] usb: usb251xb: use modern PM macros Jisheng Zhang
2025-08-24 18:58   ` Richard Leitner
2025-08-20 16:17 ` [PATCH v3 3/3] usb: usb251xb: support usage case without I2C control Jisheng Zhang
2025-08-24 18:55   ` Richard Leitner
2025-08-25 11:51     ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250822-quantum-hungry-orca-e6c6cb@kuoka \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=richard.leitner@linux.dev \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox