From: Greg KH <gregkh@linuxfoundation.org>
To: Alex Tran <alex.t.tran@gmail.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: storage: sddr09: move write buffers into info struct
Date: Mon, 1 Sep 2025 07:37:49 +0200 [thread overview]
Message-ID: <2025090126-gully-tarnish-43f1@gregkh> (raw)
In-Reply-To: <20250831192247.1120619-1-alex.t.tran@gmail.com>
On Sun, Aug 31, 2025 at 12:22:47PM -0700, Alex Tran wrote:
> Changelog:
No need for that line here, right?
> - Moved allocation of buffers ('blockbuffer', 'buffer') in
> 'sddr09_write_data' into info struct and freeing into
> 'sddr09_card_info_destructor' so that the operations are only
> performed once.
Trailing spaces :(
> - 'buffer' length is now size of a full block instead of being
> dependent on sectors.
But why are you doing any of this?
Please take a look at the kernel documentation for how to write a good
changelog text.
And do you have this device to test that your changes here work
properly?
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-01 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 19:22 [PATCH v1] usb: storage: sddr09: move write buffers into info struct Alex Tran
2025-09-01 5:37 ` Greg KH [this message]
2025-09-01 8:10 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025090126-gully-tarnish-43f1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alex.t.tran@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).