From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel@collabora.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 13/17] usb: vhci-hcd: Remove ftrace-like logging
Date: Tue, 02 Sep 2025 14:56:35 +0300 [thread overview]
Message-ID: <20250902-vhci-hcd-cleanup-v1-13-1d46247cb234@collabora.com> (raw)
In-Reply-To: <20250902-vhci-hcd-cleanup-v1-0-1d46247cb234@collabora.com>
Drop all superfluous log entries as reported by checkpatch:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
drivers/usb/usbip/vhci_hcd.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index 5b4133f08d370499bdbc50fbea7ecbbc0fbd4b71..a71a542e6eec42c79cff091fe0168f44c8c9b4b2 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -1260,8 +1260,6 @@ static int vhci_bus_suspend(struct usb_hcd *hcd)
struct vhci *vhci = *((void **)dev_get_platdata(hcd->self.controller));
unsigned long flags;
- dev_dbg(&hcd->self.root_hub->dev, "%s\n", __func__);
-
spin_lock_irqsave(&vhci->lock, flags);
hcd->state = HC_STATE_SUSPENDED;
spin_unlock_irqrestore(&vhci->lock, flags);
@@ -1275,8 +1273,6 @@ static int vhci_bus_resume(struct usb_hcd *hcd)
int rc = 0;
unsigned long flags;
- dev_dbg(&hcd->self.root_hub->dev, "%s\n", __func__);
-
spin_lock_irqsave(&vhci->lock, flags);
if (!HCD_HW_ACCESSIBLE(hcd))
@@ -1428,8 +1424,6 @@ static int vhci_hcd_suspend(struct platform_device *pdev, pm_message_t state)
int ret = 0;
unsigned long flags;
- dev_dbg(&pdev->dev, "%s\n", __func__);
-
hcd = platform_get_drvdata(pdev);
if (!hcd)
return 0;
@@ -1467,8 +1461,6 @@ static int vhci_hcd_resume(struct platform_device *pdev)
{
struct usb_hcd *hcd;
- dev_dbg(&pdev->dev, "%s\n", __func__);
-
hcd = platform_get_drvdata(pdev);
if (!hcd)
return 0;
--
2.51.0
next prev parent reply other threads:[~2025-09-02 11:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 11:56 [PATCH 00/17] USB/IP VHCI driver cleanup Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 01/17] usb: vhci-hcd: Ensure lines do not end with '(' Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 02/17] usb: vhci-hcd: Consistently use the braces Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 03/17] usb: vhci-hcd: Avoid unnecessary use of braces Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 04/17] usb: vhci-hcd: Consistently use blank lines Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 05/17] usb: vhci-hcd: Drop spaces after casts Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 06/17] usb: vhci-hcd: Add spaces around operators Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 07/17] usb: vhci-hcd: Drop unnecessary parentheses Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 08/17] usb: vhci-hcd: Fix open parenthesis alignment Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 09/17] usb: vhci-hcd: Simplify NULL comparison Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 10/17] usb: vhci-hcd: Simplify kzalloc usage Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 11/17] usb: vhci-hcd: Use the paranthesized form of sizeof Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 12/17] usb: vhci-hcd: Fix block comments Cristian Ciocaltea
2025-09-02 11:56 ` Cristian Ciocaltea [this message]
2025-09-02 11:56 ` [PATCH 14/17] usb: vhci-hcd: Consistently use __func__ Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 15/17] usb: vhci-hcd: Do not split quoted strings Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 16/17] usb: vhci-hcd: Switch to dev_err_probe() in probe path Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 17/17] usb: vhci-hcd: Replace pr_*() with dev_*() logging Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902-vhci-hcd-cleanup-v1-13-1d46247cb234@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).