From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265952BE043;
	Thu,  4 Sep 2025 07:34:18 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1756971259; cv=none; b=gj7cfDZKKixbJuysKEpx5FfTrwp/b+1MgZGBePgx5Dgc7ljSpLFmFftLImMYcAkisVr5cYTaIyLi5TWem/Lfk2crKxidd2PcxspKGeVb0E2aJsZpKFtMp0fGRhftdIqlFvTGgfZ8IM15FFdPA8lKM9QEMpQrketYbX2o+RSpxOM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1756971259; c=relaxed/simple;
	bh=Gb3dXxHLnyIdodkR1zm/mQFOrmfiQ9kM+6EHCHGDVN0=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=akNYd4P+j/HH/jl0DnMpVdN7hEiokVsmuBKpZzvLeWB+iPnTTH8EEiH4BYdLY//bUv83JlBmMyoofXnAhuujw8YDUSjGY3lGoQww/AJsRGegnAaCapq1i1x/v8sr7LicjQlSdNYdVvNvuD4oCda2wXih//Bctv48kIk+hUCaWVA=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Y3QxZhSJ; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y3QxZhSJ"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14CEDC4CEF0;
	Thu,  4 Sep 2025 07:34:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1756971258;
	bh=Gb3dXxHLnyIdodkR1zm/mQFOrmfiQ9kM+6EHCHGDVN0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Y3QxZhSJIZBfP4jM4JEwk5PDleObAscxustVWe07xtnVG6zbceiKWI6eP6rwHnALH
	 N/ukTAwlUE1i5ex6cqD2lIfuBmue4r6r/hFJkYpKMUbHTZ86a/9ocLIlTSwuUV/NqS
	 zJkDpnSGCRdr+4EleFmaRb09EkJ9Q6sthnouIlkc=
Date: Thu, 4 Sep 2025 09:34:13 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Kuen-Han Tsai <khtsai@google.com>
Cc: krzysztof.kozlowski@linaro.org, prashanth.k@oss.qualcomm.com,
	Thinh.Nguyen@synopsys.com, s.hauer@pengutronix.de,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@kernel.org
Subject: Re: [PATCH v2] usb: gadget: f_ecm: Fix ecm_opts->bound logic in bind
 path
Message-ID: <2025090401-chemo-pedigree-3556@gregkh>
References: <20250904065203.1162629-1-khtsai@google.com>
 <2025090429-snooze-womankind-77fb@gregkh>
Precedence: bulk
X-Mailing-List: linux-usb@vger.kernel.org
List-Id: <linux-usb.vger.kernel.org>
List-Subscribe: <mailto:linux-usb+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-usb+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2025090429-snooze-womankind-77fb@gregkh>

On Thu, Sep 04, 2025 at 09:33:32AM +0200, Greg KH wrote:
> On Thu, Sep 04, 2025 at 02:52:00PM +0800, Kuen-Han Tsai wrote:
> > The bound flag in ecm_opts is being set to true even if
> > gether_register_netdev() failed.
> > 
> > Move the assignment of ecm_opts->bound to after the success check to
> > ensure the flag only reflects the true state. The race condition on this
> > flag is not a concern because the caller, configfs_composite_bind(),
> > binds functions sequentially.
> > 
> > Fixes: d65e6b6e884a ("usb: gadget: f_ecm: Always set current gadget in ecm_bind()")
> > Cc: stable@kernel.org
> > Signed-off-by: Kuen-Han Tsai <khtsai@google.com>
> > ---
> >  drivers/usb/gadget/function/f_ecm.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/function/f_ecm.c
> > index 027226325039..9f5ed6f32a62 100644
> > --- a/drivers/usb/gadget/function/f_ecm.c
> > +++ b/drivers/usb/gadget/function/f_ecm.c
> > @@ -690,13 +690,14 @@ ecm_bind(struct usb_configuration *c, struct usb_function *f)
> >  
> >  	if (!ecm_opts->bound) {
> >  		status = gether_register_netdev(ecm_opts->net);
> > -		ecm_opts->bound = true;
> >  	}
> >  
> >  	mutex_unlock(&ecm_opts->lock);
> >  	if (status)
> >  		return status;
> >  
> > +	ecm_opts->bound = true;
> > +
> >  	ecm_string_defs[1].s = ecm->ethaddr;
> >  
> >  	us = usb_gstrings_attach(cdev, ecm_strings,
> > -- 
> > 2.51.0.338.gd7d06c2dae-goog
> > 
> > 
> 
> 
> Hi,
> 
> This is the friendly semi-automated patch-bot of Greg Kroah-Hartman.
> You have sent him a patch that has triggered this response.
> 
> Right now, the development tree you have sent a patch for is "closed"
> due to the timing of the merge window.  Don't worry, the patch(es) you
> have sent are not lost, and will be looked at after the merge window is
> over (after the -rc1 kernel is released by Linus).
> 
> So thank you for your patience and your patches will be reviewed at this
> later time, you do not have to do anything further, this is just a short
> note to let you know the patch status and so you don't worry they didn't
> make it through.
> 
> thanks,
> 
> greg k-h's patch email bot

Oops, nope, wrong bot, forgot to turn this one off...