From: Niklas Neronin <niklas.neronin@linux.intel.com>
To: mathias.nyman@linux.intel.com
Cc: linux-usb@vger.kernel.org, peter.chen@kernel.org,
Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: [PATCH v2 0/8] usb: xhci: Port Register Set improvements
Date: Wed, 17 Sep 2025 14:58:41 +0200 [thread overview]
Message-ID: <20250917125850.3380560-1-niklas.neronin@linux.intel.com> (raw)
The aim of this patch set is to introduce tracing for PORTSC writes and
implement a Port Register Set struct. This is the first part in a larger
series of changes.
Introduces a new struct for the Host Controller USB Port Register Set.
The current implementation accesses these registers through a single
'__le32' pointer, which, in conjunction with a macro, navigates to the
specific register using (base address + offset).
Currently, how its accessed | Register Name
--------------------------------------------------------------------------
port->addr | Port Status and Control
port->addr + PORTPMSC | Port Power Management Status and Control
port->addr + PORTLI | Port Link Info
port->addr + PORTHLPMC | Port Hardware LPM Control
After, how its accessed | Register Name
--------------------------------------------------------------------------
port->port_reg->portsc | Port Status and Control
port->port_reg->portpmsc | Port Power Management Status and Control
port->port_reg->portli | Port Link Info
port->port_reg->porthlmpc | Port Hardware LPM Control
These changes make it easier for future modification and their review.
Note:
I have chosen to split the struct changes across three separate commits
due to the substantial number of modified lines. Personally, I find that
minor typos are more likely to occur when dealing with larger patches.
However, I am open to consolidating these patches into a single commit
after review.
v2 changes:
* Fix acronym spelling to PORTSC from PORTCS, in all commit messages.
* Add patch introducing xhci_get_portsc().
Niklas Neronin (8):
usb: xhci: correct indentation for PORTSC tracing function
usb: xhci: align PORTSC trace with one-based port numbering
usb: xhci: improve xhci_decode_portsc()
usb: xhci: add tracing for PORTSC register writes
usb: xhci: add PORTSC read function
usb: xhci: add USB Port Register Set struct
usb: xhci: implement USB Port Register Set struct
usb: xhci: rename Port Register Set pointer in struct 'xhci_port'
drivers/usb/host/xhci-debugfs.c | 6 +-
drivers/usb/host/xhci-hub.c | 115 ++++++++++++++++----------------
drivers/usb/host/xhci-mem.c | 3 +-
drivers/usb/host/xhci-pci.c | 4 +-
drivers/usb/host/xhci-ring.c | 2 +-
drivers/usb/host/xhci-tegra.c | 12 ++--
drivers/usb/host/xhci-trace.h | 39 ++++++-----
drivers/usb/host/xhci.c | 46 ++++++++-----
drivers/usb/host/xhci.h | 95 +++++++++++++-------------
9 files changed, 167 insertions(+), 155 deletions(-)
--
2.50.1
next reply other threads:[~2025-09-17 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 12:58 Niklas Neronin [this message]
2025-09-17 12:58 ` [PATCH v2 1/8] usb: xhci: correct indentation for PORTSC tracing function Niklas Neronin
2025-09-17 12:58 ` [PATCH v2 2/8] usb: xhci: align PORTSC trace with one-based port numbering Niklas Neronin
2025-09-17 21:14 ` Mathias Nyman
2025-09-17 12:58 ` [PATCH v2 3/8] usb: xhci: improve xhci_decode_portsc() Niklas Neronin
2025-09-17 12:58 ` [PATCH v2 4/8] usb: xhci: add tracing for PORTSC register writes Niklas Neronin
2025-09-19 11:54 ` kernel test robot
2025-09-17 12:58 ` [PATCH v2 5/8] usb: xhci: add PORTSC read function Niklas Neronin
2025-09-20 16:19 ` kernel test robot
2025-09-17 12:58 ` [PATCH v2 6/8] usb: xhci: add USB Port Register Set struct Niklas Neronin
2025-09-17 12:58 ` [PATCH v2 7/8] usb: xhci: implement " Niklas Neronin
2025-09-17 12:58 ` [PATCH v2 8/8] usb: xhci: rename Port Register Set pointer in struct 'xhci_port' Niklas Neronin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917125850.3380560-1-niklas.neronin@linux.intel.com \
--to=niklas.neronin@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox