linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>,
	Michal Pecio <michal.pecio@gmail.com>,
	Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: [PATCH 2/6] usb: xhci: Update a comment about Stop Endpoint retries
Date: Thu, 18 Sep 2025 00:07:21 +0300	[thread overview]
Message-ID: <20250917210726.97100-3-mathias.nyman@linux.intel.com> (raw)
In-Reply-To: <20250917210726.97100-1-mathias.nyman@linux.intel.com>

From: Michal Pecio <michal.pecio@gmail.com>

Retries are no longer gated by a quirk, so remove that part.
Add a brief explanation of the timeout.

Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
 drivers/usb/host/xhci-ring.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 6309200e93dc..e3d0e2e0312e 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -1262,8 +1262,9 @@ static void xhci_handle_cmd_stop_ep(struct xhci_hcd *xhci, int slot_id,
 			 * Stopped state, but it will soon change to Running.
 			 *
 			 * Assume this bug on unexpected Stop Endpoint failures.
-			 * Keep retrying until the EP starts and stops again, on
-			 * chips where this is known to help. Wait for 100ms.
+			 * Keep retrying until the EP starts and stops again or
+			 * up to a timeout (a defective HC may never start, or a
+			 * driver bug may cause stopping an already stopped EP).
 			 */
 			if (time_is_before_jiffies(ep->stop_time + msecs_to_jiffies(100)))
 				break;
-- 
2.43.0


  parent reply	other threads:[~2025-09-17 21:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 21:07 [PATCH 0/6] xhci features for usb-next Mathias Nyman
2025-09-17 21:07 ` [PATCH 1/6] Revert "usb: xhci: Avoid Stop Endpoint retry loop if the endpoint seems Running" Mathias Nyman
2025-09-17 21:07 ` Mathias Nyman [this message]
2025-09-17 21:07 ` [PATCH 3/6] usb: xhci-pci: add support for hosts with zero USB3 ports Mathias Nyman
2025-10-22 20:25   ` Dirk Gouders
2025-10-22 21:34     ` Michal Pecio
2025-10-23  5:13       ` Dirk Gouders
2025-09-17 21:07 ` [PATCH 4/6] usb: xhci: improve TR Dequeue Pointer mask Mathias Nyman
2025-09-17 21:07 ` [PATCH 5/6] usb: xhci: correct indentation for PORTSC tracing function Mathias Nyman
2025-09-17 21:07 ` [PATCH 6/6] usb: xhci: align PORTSC trace with one-based port numbering Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917210726.97100-3-mathias.nyman@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.pecio@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).