From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>,
Niklas Neronin <niklas.neronin@linux.intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: [PATCH 6/6] usb: xhci: align PORTSC trace with one-based port numbering
Date: Thu, 18 Sep 2025 00:07:25 +0300 [thread overview]
Message-ID: <20250917210726.97100-7-mathias.nyman@linux.intel.com> (raw)
In-Reply-To: <20250917210726.97100-1-mathias.nyman@linux.intel.com>
From: Niklas Neronin <niklas.neronin@linux.intel.com>
In the xHCI driver, port numbers are typically described using a one-based
index. However, tracing currently uses a zero-based index. To ensure
consistency between tracing and dynamic debugging, update the trace port
number to use a one-based index.
Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
drivers/usb/host/xhci-trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h
index f303ce600ff5..9abc904f1749 100644
--- a/drivers/usb/host/xhci-trace.h
+++ b/drivers/usb/host/xhci-trace.h
@@ -550,7 +550,7 @@ DECLARE_EVENT_CLASS(xhci_log_portsc,
),
TP_fast_assign(
__entry->busnum = port->rhub->hcd->self.busnum;
- __entry->portnum = port->hcd_portnum;
+ __entry->portnum = port->hcd_portnum + 1;
__entry->portsc = portsc;
),
TP_printk("port %d-%d: %s",
--
2.43.0
prev parent reply other threads:[~2025-09-17 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 21:07 [PATCH 0/6] xhci features for usb-next Mathias Nyman
2025-09-17 21:07 ` [PATCH 1/6] Revert "usb: xhci: Avoid Stop Endpoint retry loop if the endpoint seems Running" Mathias Nyman
2025-09-17 21:07 ` [PATCH 2/6] usb: xhci: Update a comment about Stop Endpoint retries Mathias Nyman
2025-09-17 21:07 ` [PATCH 3/6] usb: xhci-pci: add support for hosts with zero USB3 ports Mathias Nyman
2025-10-22 20:25 ` Dirk Gouders
2025-10-22 21:34 ` Michal Pecio
2025-10-23 5:13 ` Dirk Gouders
2025-09-17 21:07 ` [PATCH 4/6] usb: xhci: improve TR Dequeue Pointer mask Mathias Nyman
2025-09-17 21:07 ` [PATCH 5/6] usb: xhci: correct indentation for PORTSC tracing function Mathias Nyman
2025-09-17 21:07 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917210726.97100-7-mathias.nyman@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=niklas.neronin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).