Re: [PATCH 10/39] convert smackfs

Casey Schaufler
2025-09-22T15:31:29Z

On 9/20/2025 12:47 AM, Al Viro wrote:
> Entirely static tree populated by simple_fill_super(). Can use
> kill_anon_super() as-is.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Looks fine to me.
Acked-by: Casey Schaufler <casey@schaufler-ca.com>

> ---
> security/smack/smackfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index b1e5e62f5cbd..e989ae3890c7 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -2960,7 +2960,7 @@ static int smk_init_fs_context(struct fs_context *fc)
> static struct file_system_type smk_fs_type = {
> .name = "smackfs",
> .init_fs_context = smk_init_fs_context,
> - .kill_sb = kill_litter_super,
> + .kill_sb = kill_anon_super,
> };
>
> static struct vfsmount *smackfs_mount;