Re: [PATCH 08/39] configfs, securityfs: kill_litter_super() not needed

Joel Becker
2025-09-24T16:56:41Z

Reviewed-by: Joel Becker <jlbec@evilplan.org>

On Sat, Sep 20, 2025 at 08:47:27AM +0100, Al Viro wrote:
> These are guaranteed to be empty by the time they are shut down;
> both are single-instance and there is an internal mount maintained
> for as long as there is any contents.
>
> Both have that internal mount pinned by every object in root.
>
> In other words, kill_litter_super() boils down to kill_anon_super()
> for those.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> fs/configfs/mount.c | 2 +-
> security/inode.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c
> index 740f18b60c9d..fa66e25f0d75 100644
> --- a/fs/configfs/mount.c
> +++ b/fs/configfs/mount.c
> @@ -116,7 +116,7 @@ static struct file_system_type configfs_fs_type = {
> .owner = THIS_MODULE,
> .name = "configfs",
> .init_fs_context = configfs_init_fs_context,
> - .kill_sb = kill_litter_super,
> + .kill_sb = kill_anon_super,
> };
> MODULE_ALIAS_FS("configfs");
>
> diff --git a/security/inode.c b/security/inode.c
> index 43382ef8896e..bf7b5e2e6955 100644
> --- a/security/inode.c
> +++ b/security/inode.c
> @@ -70,7 +70,7 @@ static struct file_system_type fs_type = {
> .owner = THIS_MODULE,
> .name = "securityfs",
> .init_fs_context = securityfs_init_fs_context,
> - .kill_sb = kill_litter_super,
> + .kill_sb = kill_anon_super,
> };
>
> /**
> --
> 2.47.3
>
>

--

The Graham Corollary:

The longer a socially-moderated news website exists, the
probability of an old Paul Graham link appearing at the top
approaches certainty.

http://www.jlbec.org/
jlbec@evilplan.org