From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96A3A2D839B for ; Wed, 24 Sep 2025 09:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758706625; cv=none; b=QViBRpi81BFv+Sbf8r4YK24zHcEfHxuNAFtnPb+3+vXyql0S0r7l3fpOBQ33tmkMAnbaQvI7Sdj87isMDX9pW26BcU0/WcAiLzO6am5grQyZWc4gknbh+R7Xv4z2yTFiosqLcSvk/6/zm/TR65vN8bHxUu5/o7hxHc5xQV2p+q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758706625; c=relaxed/simple; bh=tHDZPTjqsvGSVtD2vzi+B0EfyL6Wl8yhlQVaMzP6+5o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fG+Otcd/1i6D1i1dscchO3Dl3EFJXR0EpXz+4mEHPIGdvQug7LUc68tkNrwHZeavNJglf9yU4PDMgfNfwacaWBbU9evPxQv+YTOS29pdvteO9svypQVGrd/d64B2Q/MXlF3uYL3d/KslJV2RrteAF8tHf7VSqSJN7Pzzzr/zSss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dOUeeZW7; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dOUeeZW7" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-363f137bbf8so48839021fa.2 for ; Wed, 24 Sep 2025 02:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758706619; x=1759311419; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EfQjDW9lOZhqCcu0UR8GmRDS7/f9HDxq+dUiuWeXOX8=; b=dOUeeZW7JrZiu+ESKbVavy5wTYbdqQl9588/A6PDdjGhRUsmYzMq61bYJUeh5529gB SbqVQa+Z2mV0OSNb7Yk9t7dCunhR/+iO+DLQ+Dog5L96DfmySOQbJkKNzljeDuNLasyx ISET203X4CWrHT1+VK6RJsd09aJxps1M4teHSZFioQnPGmidNZ+mdIfBATyFKQEZzOnu gMfXR/sMao54f0BqIRAlSj0RO/n9GZnN4dL7XPEtfUOrcyAnhA6eGRUUX7LuKaGu2WiP aTB0o0QkononnFBw85tNHSiBn+OEuimDokMWeFs3Znr2XPY+dkSB+1U2risufOjne62U N6Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758706619; x=1759311419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EfQjDW9lOZhqCcu0UR8GmRDS7/f9HDxq+dUiuWeXOX8=; b=QpZBqaO6ThT2YkD2ccE5muvbuKYUmek5lEb2F7YP/Hflcad2Sss6hnsRRgu5I4BdBu Rx4/QdtgKXzDkkY4UoeLvq49knDzOk1xDpBc8G4e0rsq8DapIBlMKUbdZM4PKNdqKcPs xbbSDC4VNSXM23nSrRmsMPKFpRmTos78ezS4nYoHdzfgdZ4ULhNcc2/FZ3our3c+WMS8 WIKFhs/b+CCRS3b7flNbmc1szv01ySRp0fejFSnOHcErZtguFn1z2Kr5jbYACKTFHeyZ 7wagLpO2uBclRzlPo1zL4B3tYdoigr+5fxnyqPWIYbbZX7E0IvpM8zF86GGF9sTZRBmM 8MCQ== X-Forwarded-Encrypted: i=1; AJvYcCVDfZ7l39ycDPEkSzr0O/V2RP09fXPZfPlIEiVf9eVzuH9KFAvwLBJxzneChC/pl+zQ4yObfgLAal0=@vger.kernel.org X-Gm-Message-State: AOJu0YzHv7SasRTx6zUae+eA8rpVQ/MZyB+QcW878flCNxOJKmHUosrs f1m6xazNAELMa8cIH0mOB1bwnBUzSARyUrmdP4o5YyX8FTXOTLlQ1ZaP X-Gm-Gg: ASbGncuSq+Z00I5Tb4xl38pfWA3hTfjvKLNZnKnzAIm6qm0vYK6DoVImDjLOB8KA7s0 J8tdYPaZRXijammsNibfQRnGeC/UryrJeXIVNpMDqHRDRUSBCFb02wlOkXcIVIgn1XDEnI7nQ0g BQrLYFwkz5Z9HOV4yVMwecznN7eOyJ5S8VbK+fiIyLY5zpVyNuPLtSVsgzcs0RDXJa7rU58RqFh nq6bz+4XEjeyZKIHJ7Kz2rdwDutoe8tXzLuKDje3/DS34QK+VkkLXCRgYZCaJo/Y5GBuq/AwfBL TYmrwOwwLUklA4EcU443a8WdM5xefSTGcm1mnfa1WphJQC1gnXw+x3qcvZjm+ecT8jV8wEyaJ2w iRMfKcLxML/uJ4LTOpnxQbocVfUOGStLDXNQ= X-Google-Smtp-Source: AGHT+IGAXIFBfltfcFUi2JvMXFLpdNu20IBm9lusClOWXvJ5IvB5Xvu2p2lzfwLhA2Gs0+4M6+OmAw== X-Received: by 2002:a2e:b8d2:0:b0:36a:f4d3:82e9 with SMTP id 38308e7fff4ca-36d14ebb0b5mr14965271fa.6.1758706618408; Wed, 24 Sep 2025 02:36:58 -0700 (PDT) Received: from foxbook (bfe191.neoplus.adsl.tpnet.pl. [83.28.42.191]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-361a26cbbd6sm43990051fa.23.2025.09.24.02.36.57 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 24 Sep 2025 02:36:58 -0700 (PDT) Date: Wed, 24 Sep 2025 11:36:53 +0200 From: Michal Pecio To: viswanath Cc: andrew@lunn.ch, andrew+netdev@lunn.ch, davem@davemloft.net, david.hunter.linux@gmail.com, edumazet@google.com, kuba@kernel.org, linux-kernel-mentees@lists.linux.dev, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, petkan@nucleusys.com, skhan@linuxfoundation.org, syzbot+78cae3f37c62ad092caa@syzkaller.appspotmail.com Subject: Re: [PATCH net v2] net: usb: Remove disruptive netif_wake_queue in rtl8150_set_multicast Message-ID: <20250924113653.5dad5e50.michal.pecio@gmail.com> In-Reply-To: References: <83171a57-cb40-4c97-b736-0e62930b9e5c@lunn.ch> <20250920181852.18164-1-viswanathiyyappan@gmail.com> <20250924094741.65e12028.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Sep 2025 13:32:52 +0530, viswanath wrote: > On Wed, 24 Sept 2025 at 13:17, Michal Pecio wrote: > > > > It's not freeing which matters but URB completion in the USB subsystem. > > Does URB completion include both successful and failed completions? I > decided to go with "free urb" because I wasn't sure of that. I think yes, usually in USB-speak "completion" is when the URB is finished for any reason, including error or unlink/cancellation. "Free" could suggest usb_free_urb(). But I see your point. Maybe "finish execution" is less ambiguous? > I wasn't sure how to describe the flow of execution in a multi threaded program. > I will resubmit a v3 with this version of the execution flow I think it's an irrelevant detail which CPU executed which function. It could all happen sequentially on a single core and it's still the same bug. In fact, I just reproduced it with all CPUs offlined except one.