linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jameson Thies <jthies@google.com>
To: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Cc: jthies@google.com, dmitry.baryshkov@oss.qualcomm.com,
	bleung@chromium.org,  gregkh@linuxfoundation.org,
	akuchynski@chromium.org,  abhishekpandit@chromium.org,
	sebastian.reichel@collabora.com,  linux-pm@vger.kernel.org
Subject: [PATCH 5/6] usb: typec: ucsi: psy: Set max current to zero when disconnected
Date: Tue,  7 Oct 2025 00:00:06 +0000	[thread overview]
Message-ID: <20251007000007.3724229-6-jthies@google.com> (raw)
In-Reply-To: <20251007000007.3724229-1-jthies@google.com>

The ucsi_psy_get_current_max function defaults to 0.1A when it is not
clear how much current the partner device can support. But this does
not check the port is connected, and will report 0.1A max current when
nothing is connected. Update ucsi_psy_get_current_max to report 0A when
there is no connection.

Signed-off-by: Jameson Thies <jthies@google.com>
---
 drivers/usb/typec/ucsi/psy.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/typec/ucsi/psy.c b/drivers/usb/typec/ucsi/psy.c
index 985a90d3f898..3a209de55c14 100644
--- a/drivers/usb/typec/ucsi/psy.c
+++ b/drivers/usb/typec/ucsi/psy.c
@@ -169,6 +169,11 @@ static int ucsi_psy_get_current_max(struct ucsi_connector *con,
 {
 	u32 pdo;
 
+	if (!UCSI_CONSTAT(con, CONNECTED)) {
+		val->intval = 0;
+		return 0;
+	}
+
 	switch (UCSI_CONSTAT(con, PWR_OPMODE)) {
 	case UCSI_CONSTAT_PWR_OPMODE_PD:
 		if (con->num_pdos > 0) {
-- 
2.51.0.618.g983fd99d29-goog


  parent reply	other threads:[~2025-10-07  0:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07  0:00 [PATCH 0/6] UCSI Power Supply Updates and Bug Fixes Jameson Thies
2025-10-07  0:00 ` [PATCH 1/6] usb: typec: ucsi: psy: Add power supply status Jameson Thies
2025-10-08 12:53   ` Heikki Krogerus
2025-10-07  0:00 ` [PATCH 2/6] usb: typec: ucsi: psy: Add support for DRP USB type Jameson Thies
2025-10-07 23:50   ` Benson Leung
2025-10-08 13:02   ` Heikki Krogerus
2025-10-13 20:44     ` Jameson Thies
2025-10-07  0:00 ` [PATCH 3/6] usb: typec: ucsi: Report power supply changes on power opmode changes Jameson Thies
2025-10-07 23:51   ` Benson Leung
2025-10-08 13:02   ` Heikki Krogerus
2025-10-07  0:00 ` [PATCH 4/6] usb: typec: ucsi: Report power supply change on sink path change Jameson Thies
2025-10-07 23:52   ` Benson Leung
2025-10-08 13:06   ` Heikki Krogerus
2025-10-13 20:45     ` Jameson Thies
2025-10-07  0:00 ` Jameson Thies [this message]
2025-10-07 23:55   ` [PATCH 5/6] usb: typec: ucsi: psy: Set max current to zero when disconnected Benson Leung
2025-10-08 13:08   ` Heikki Krogerus
2025-10-07  0:00 ` [PATCH 6/6] usb: typec: ucsi: pr_swap should check connector_status Jameson Thies
2025-10-07 23:56   ` Benson Leung
2025-10-08 13:10   ` Heikki Krogerus
2025-10-13 20:56     ` Jameson Thies
2025-10-13  7:33 ` [PATCH 0/6] UCSI Power Supply Updates and Bug Fixes Greg KH
2025-10-13 20:59   ` Jameson Thies
2025-10-14  5:19     ` Greg KH
2025-10-13 21:02 ` Kenneth Crudup
2025-10-13 22:53   ` Jameson Thies
2025-10-13 23:26     ` Kenneth Crudup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251007000007.3724229-6-jthies@google.com \
    --to=jthies@google.com \
    --cc=abhishekpandit@chromium.org \
    --cc=akuchynski@chromium.org \
    --cc=bleung@chromium.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).