From: Conor Dooley <conor@kernel.org>
To: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: ti,hd3ss3220: Add support for VBUS based on ID state
Date: Wed, 8 Oct 2025 21:53:18 +0100 [thread overview]
Message-ID: <20251008-reclusive-cilantro-cafe98a62922@spud> (raw)
In-Reply-To: <20251002172539.586538-2-krishna.kurapati@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 1923 bytes --]
On Thu, Oct 02, 2025 at 10:55:38PM +0530, Krishna Kurapati wrote:
> Update the bindings to support reading ID state and VBUS, as per the
> HD3SS3220 data sheet. The ID pin is kept high if VBUS is not at VSafe0V and
> asserted low once VBUS is at VSafe0V, enforcing the Type-C requirement that
> VBUS must be at VSafe0V before re-enabling VBUS.
>
> Add id-gpios property to describe the input gpio for USB ID pin and vbus-
> supply property to describe the regulator for USB VBUS.
IDK anything about this class of USB device, but I think the binding
patch is acceptable.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> .../devicetree/bindings/usb/ti,hd3ss3220.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> index bec1c8047bc0..c869eece39a7 100644
> --- a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> @@ -25,6 +25,19 @@ properties:
> interrupts:
> maxItems: 1
>
> + id-gpios:
> + description:
> + An input gpio for USB ID pin. Upon detecting a UFP device, HD3SS3220
> + will keep ID pin high if VBUS is not at VSafe0V. Once VBUS is at VSafe0V,
> + the HD3SS3220 will assert ID pin low. This is done to enforce Type-C
> + requirement that VBUS must be at VSafe0V before re-enabling VBUS.
> +
> + maxItems: 1
> +
> + vbus-supply:
> + description: A phandle to the regulator for USB VBUS if needed when host
> + mode or dual role mode is supported.
> +
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> description: OF graph bindings (specified in bindings/graph.txt) that model
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-10-08 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 17:25 [PATCH 0/2] Implement vbus support for HD3SS3220 port controller Krishna Kurapati
2025-10-02 17:25 ` [PATCH 1/2] dt-bindings: usb: ti,hd3ss3220: Add support for VBUS based on ID state Krishna Kurapati
2025-10-08 20:53 ` Conor Dooley [this message]
2025-10-02 17:25 ` [PATCH 2/2] usb: typec: hd3ss3220: Enable VBUS based on ID pin state Krishna Kurapati
2025-10-03 5:56 ` kernel test robot
2025-10-08 11:09 ` Heikki Krogerus
2025-10-08 11:15 ` Krishna Kurapati PSSNV
2025-10-08 13:30 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251008-reclusive-cilantro-cafe98a62922@spud \
--to=conor@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox