Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
	kernel@collabora.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/17] USB/IP VHCI driver cleanup
Date: Wed, 8 Oct 2025 13:00:04 +0200	[thread overview]
Message-ID: <2025100839-lent-smother-9527@gregkh> (raw)
In-Reply-To: <eb86ebd0-71ff-4c00-a524-0046b86b3aa6@linuxfoundation.org>

On Wed, Sep 24, 2025 at 02:44:07PM -0600, Shuah Khan wrote:
> On 9/2/25 05:56, Cristian Ciocaltea wrote:
> > These patches were initially part of the USB/IP VHCI suspend fix series
> > [1] to address a bunch of coding style issues and make checkpatch happy
> > for the entire driver.
> > 
> > As suggested by Greg, I'm sending this as a separate patch set now.
> > 
> > [1] https://lore.kernel.org/r/20250726-vhci-hcd-suspend-fix-v2-0-189266dfdfaa@collabora.com
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> > ---
> > Cristian Ciocaltea (17):
> >        usb: vhci-hcd: Ensure lines do not end with '('
> >        usb: vhci-hcd: Consistently use the braces
> >        usb: vhci-hcd: Avoid unnecessary use of braces
> >        usb: vhci-hcd: Consistently use blank lines
> >        usb: vhci-hcd: Drop spaces after casts
> >        usb: vhci-hcd: Add spaces around operators
> >        usb: vhci-hcd: Drop unnecessary parentheses
> >        usb: vhci-hcd: Fix open parenthesis alignment
> >        usb: vhci-hcd: Simplify NULL comparison
> >        usb: vhci-hcd: Simplify kzalloc usage
> >        usb: vhci-hcd: Use the paranthesized form of sizeof
> >        usb: vhci-hcd: Fix block comments
> >        usb: vhci-hcd: Remove ftrace-like logging
> >        usb: vhci-hcd: Consistently use __func__
> >        usb: vhci-hcd: Do not split quoted strings
> 
> >        usb: vhci-hcd: Switch to dev_err_probe() in probe path
> >        usb: vhci-hcd: Replace pr_*() with dev_*() logging
> 
> I acked the 16/17 and 17/17 - others I don't see a reason for code
> churn.

Great!  Christian, can you resend just those two patches as a series
with Shuah's ack on them for me to pick up?

thanks,

greg k-h

  reply	other threads:[~2025-10-08 11:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 11:56 [PATCH 00/17] USB/IP VHCI driver cleanup Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 01/17] usb: vhci-hcd: Ensure lines do not end with '(' Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 02/17] usb: vhci-hcd: Consistently use the braces Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 03/17] usb: vhci-hcd: Avoid unnecessary use of braces Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 04/17] usb: vhci-hcd: Consistently use blank lines Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 05/17] usb: vhci-hcd: Drop spaces after casts Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 06/17] usb: vhci-hcd: Add spaces around operators Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 07/17] usb: vhci-hcd: Drop unnecessary parentheses Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 08/17] usb: vhci-hcd: Fix open parenthesis alignment Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 09/17] usb: vhci-hcd: Simplify NULL comparison Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 10/17] usb: vhci-hcd: Simplify kzalloc usage Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 11/17] usb: vhci-hcd: Use the paranthesized form of sizeof Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 12/17] usb: vhci-hcd: Fix block comments Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 13/17] usb: vhci-hcd: Remove ftrace-like logging Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 14/17] usb: vhci-hcd: Consistently use __func__ Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 15/17] usb: vhci-hcd: Do not split quoted strings Cristian Ciocaltea
2025-09-02 11:56 ` [PATCH 16/17] usb: vhci-hcd: Switch to dev_err_probe() in probe path Cristian Ciocaltea
2025-09-24 20:40   ` Shuah Khan
2025-09-02 11:56 ` [PATCH 17/17] usb: vhci-hcd: Replace pr_*() with dev_*() logging Cristian Ciocaltea
2025-09-24 20:41   ` Shuah Khan
2025-09-24 20:44 ` [PATCH 00/17] USB/IP VHCI driver cleanup Shuah Khan
2025-10-08 11:00   ` Greg Kroah-Hartman [this message]
2025-10-08 17:00     ` Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025100839-lent-smother-9527@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=i@zenithal.me \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox