From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ACCB2FE584 for ; Mon, 13 Oct 2025 09:43:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760348631; cv=none; b=ZBFkRrKrLqmvGt1dYu0J0WKxPqGVbdpDUiAFsIasngzvXolgzBjaaC5vU4Srko58rbcIgesAXC4pZqM6SWL0bpvkzf5uYQFw/pbRmtS6AWA/w4M9ekViIKhJVJtvvDjA75iSKxF/m+Jl1shymA9SRwXuWxu6y4a4psRG4U8B/uA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760348631; c=relaxed/simple; bh=6I3vbFqrC8hpi6PcBC7EqlmHPrHJF/Who5etpts5xAo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=NfUNIGGPBEvrObRyV+RqVfSMeiJ7OFeRgpJYpfhT2KI8eNDlKRzOnhytyBk2R5b/OmP7gEfO74jsY0Y7kvbf2HnzgSshWRfeEPncpNkB40HCaz0VN7lSjmuW7+uD0En86zOO5YIV09kYEm8VqfgFcOgLLUhhttJSpQvGEbvbG4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v8F5i-0004bA-3c; Mon, 13 Oct 2025 11:43:42 +0200 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v8F5h-003MXH-14; Mon, 13 Oct 2025 11:43:41 +0200 Received: from localhost ([::1] helo=dude04.red.stw.pengutronix.de) by dude04.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1v8F5h-00000005PWJ-148F; Mon, 13 Oct 2025 11:43:41 +0200 From: Michael Grzeschik Date: Mon, 13 Oct 2025 11:43:40 +0200 Subject: [PATCH v2] tcpm: switch check for role_sw device with fw_node Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-b4-ml-topic-tcpm-v2-1-63c9b2ab8a0b@pengutronix.de> X-B4-Tracking: v=1; b=H4sIAMvJ7GgC/32NSw6DIBRFt2LeuK8B/GA66j4aBwpUX1KBACU2x r2XuoAOz0nuuTtEE8hEuFU7BJMpkrMFxKUCtYx2Nki6MAgmWs5YjVOD6wuT86QwKb+ikLzppJB adiOUmQ/mSduZfAyFF4rJhc/5kPnP/olljhxrpTVr274f1XT3xs7vFJyl7aoNDMdxfAGm8Bitt QAAAA== X-Change-ID: 20251003-b4-ml-topic-tcpm-27146727d76a To: Badhri Jagan Sridharan , Heikki Krogerus , Greg Kroah-Hartman Cc: kernel@pengutronix.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michael Grzeschik X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1956; i=m.grzeschik@pengutronix.de; h=from:subject:message-id; bh=6I3vbFqrC8hpi6PcBC7EqlmHPrHJF/Who5etpts5xAo=; b=owEBbQKS/ZANAwAKAb9pWET5cfSrAcsmYgBo7MnMdESNHo1oHL+TIzCTJWUxgtXZSxdrszpPq C9+FgsLmk6JAjMEAAEKAB0WIQQV2+2Fpbqd6fvv0Gi/aVhE+XH0qwUCaOzJzAAKCRC/aVhE+XH0 qyLdEAC0HfkrZDmd4Ins3Cm3NudISCVaNHEVcNOVnUuUwOLNExKAxfMuptvlQodUkmI8WohV4qX mGybcGXt8uBYdfVQEg2RcJi+aEW5fCfQNvxI7zFGko8Itw3AWVXUD574Ay8bs2g8BWl+k9ygux6 SetYhpdSqhLAJM8lzpkyl7yEmIFpjIAGg4Kkw+UhPFI25JciWG8tcOOiM886JbDAtmBZUZkUKaT 8qRY3dgsFYEMhkYrWYf+4upACzhMW+1ctgGVon0g3doM7Ofz49WCmxu8Ve9c8pBj2Ehb4PBnbux NBG+cgCSiS2qcawhWFO/FagkrmgFW3jFf25ZCG5zxadyc0cAFH6Jaudnxv1TZucvd//Q2TN3SZe Up7ni4Bz0U6u9jc91M5sObSG5q8pIa1z4/uq+i8Q/Etu5EWY4hLlLR68hkAyVRUyW0ql04wy1M7 Qud1GY4zM11+X76YtYGJlqfDZzRbCDwWUoc+ZIrwbYE24vk/+oFgA8cHF5PKWm5fYOaFAsZlfga VBWTv3MbUjRgT5iFhbCi4BVtmjpWQPrQM357+cNR4J9pWwe4+GPAaRMkaun5pkfn5KGheVH0rQA KZ/3BQBObm+vTpu2snSXmWKkb/JhL+8jcLZ3lYUy1STHgcuwKfiXpoCqDHlAASCrngZ3k0kEDum b42WoCvjGL+mHcg== X-Developer-Key: i=m.grzeschik@pengutronix.de; a=openpgp; fpr=957BC452CE953D7EA60CF4FC0BE9E3157A1E2C64 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.grzeschik@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-usb@vger.kernel.org When there is no port entry in the tcpci entry itself, the driver will trigger an error message "OF: graph: no port node found in /...../typec" . It is documented that the dts node should contain an connector entry with ports and several port pointing to devices with usb-role-switch property set. Only when those connector entry is missing, it should check for port entries in the main node. We switch the search order for looking after ports, which will avoid the failure message while there are explicit connector entries. Fixes: d56de8c9a17d ("usb: typec: tcpm: try to get role switch from tcpc fwnode") Cc: stable@vger.kernel.org Signed-off-by: Michael Grzeschik --- Changes in v2: - fixed typos in the description - added fixes tag - added Cc: stable@vger.kernel.org - Link to v1: https://lore.kernel.org/r/20251003-b4-ml-topic-tcpm-v1-1-3cdd05588acb@pengutronix.de --- drivers/usb/typec/tcpm/tcpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index b2a568a5bc9b0ba5c50b7031d8e21ee09cefa349..cc78770509dbc6460d75816f544173d6ab4ef873 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -7876,9 +7876,9 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) port->partner_desc.identity = &port->partner_ident; - port->role_sw = usb_role_switch_get(port->dev); + port->role_sw = fwnode_usb_role_switch_get(tcpc->fwnode); if (!port->role_sw) - port->role_sw = fwnode_usb_role_switch_get(tcpc->fwnode); + port->role_sw = usb_role_switch_get(port->dev); if (IS_ERR(port->role_sw)) { err = PTR_ERR(port->role_sw); goto out_destroy_wq; --- base-commit: e406d57be7bd2a4e73ea512c1ae36a40a44e499e change-id: 20251003-b4-ml-topic-tcpm-27146727d76a Best regards, -- Michael Grzeschik