From: Greg KH <gregkh@linuxfoundation.org>
To: vsshingne <vaibhavshingne66@gmail.com>
Cc: skhan@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: core: prevent double URB enqueue causing list corruption
Date: Fri, 31 Oct 2025 14:59:25 +0100 [thread overview]
Message-ID: <2025103113-unbutton-harmful-e569@gregkh> (raw)
In-Reply-To: <20251031135032.222938-1-vaibhavshingne66@gmail.com>
On Fri, Oct 31, 2025 at 07:20:32PM +0530, vsshingne wrote:
> Prevents the same URB from being enqueued twice on the same endpoint,
> which could lead to list corruption detected by list_debug.c.
>
> This was observed in syzbot reports where URBs were re-submitted
> before completion, triggering 'list_add double add' errors.
>
> Adding a check to return if the URB is already on a queue
> prevents this corruption.
>
> Signed-off-by: vsshingne <vaibhavshingne66@gmail.com>
> ---
> drivers/usb/core/hcd.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Please do not send patches multiple times, in invalid formats.
next prev parent reply other threads:[~2025-10-31 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 13:50 [PATCH] usb: core: prevent double URB enqueue causing list corruption vsshingne
2025-10-31 13:59 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-31 13:47 vsshingne
2025-10-31 13:59 ` Greg KH
2025-10-31 14:13 ` Alan Stern
2025-10-31 17:21 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025103113-unbutton-harmful-e569@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vaibhavshingne66@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox