Re: [PATCH] rust: usb: fix broken call to T::disconnect()

Danilo Krummrich
2025-11-03T23:28:21Z

On Mon Nov 3, 2025 at 11:56 PM CET, Greg KH wrote:
> On Mon, Nov 03, 2025 at 12:01:03PM +0100, Danilo Krummrich wrote:
>> A refactoring of Device::drvdata_obtain() broke T::disconnect() in the
>> USB abstractions.
>>
>> """
>> error[E0599]: no method named `data` found for struct `core::pin::Pin<kbox::Box<T, Kmalloc>>` in the current scope
>> --> rust/kernel/usb.rs:92:34
>> |
>> 92 | T::disconnect(intf, data.data());
>> | ^^^^ method not found in `core::pin::Pin<kbox::Box<T, Kmalloc>>`
>>
>> error: aborting due to 1 previous error
>>
>> For more information about this error, try `rustc --explain E0599`.
>> make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
>> make[1]: *** [/builddir/build/BUILD/kernel-6.18.0-build/kernel-next-20251103/linux-6.18.0-0.0.next.20251103.436.vanilla.fc44.x86_64/Makefile:1316: prepare] Error 2
>> make: *** [Makefile:256: __sub-make] Error 2
>> """
>>
>> This slipped through, since the USB abstractions are globally disabled.
>> However, the USB tree recently enabled them, hence it showed up in
>> linux-next.
>
> Sorry about this, should we also enable it in the driver-core-next tree
> as well, to catch these types of things?

No worries -- I actually enabled it locally, but then forgot to re-test after a
rebase.

I'm fine either way, I only expect one more patch touching the USB stuff in this
cycle.