From: Greg KH <gregkh@linuxfoundation.org>
To: jerry xzq <jerry.xzq@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
treapking@google.com
Subject: Re: [PATCH] USB: of: filter disabled device node
Date: Sat, 22 Nov 2025 13:32:24 +0100 [thread overview]
Message-ID: <2025112206-handwork-hush-5886@gregkh> (raw)
In-Reply-To: <CAD48c-Vp0gJZpBu0BobooWjKBksNJ+CcCTQRw1mzspoO2Zs5yA@mail.gmail.com>
On Sat, Nov 22, 2025 at 07:49:02PM +0800, jerry xzq wrote:
> On Sat, Nov 22, 2025 at 7:32 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, Nov 22, 2025 at 07:25:39PM +0800, Zhengqiao Xia wrote:
> > > We should not point the of_node of a USB device to a disabled devicetree
> > > node. Otherwise, the interface under this USB device will not be able
> > > to register.
> >
> > Why would a USB device point to a disabled device tree node? Shouldn't
> > the device tree be fixed instead?
>
> According to your suggestion, when a USB device is directly connected
> to a USB port,
> we should delete the unused USB hub node instead of disabling it?
Why are you using device tree to describe USB devices at all? What is
the root problem here that you are trying to solve?
The use of USB in DT should be _VERY_ limited, if at all. You should
only do so for very good reasons in very limited situations. If this
starts to get abused, we'll just have to rip it all out :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-11-22 12:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 11:25 [PATCH] USB: of: filter disabled device node Zhengqiao Xia
2025-11-22 11:31 ` Greg KH
2025-11-22 11:32 ` Greg KH
2025-11-22 11:49 ` jerry xzq
2025-11-22 12:32 ` Greg KH [this message]
2025-11-22 12:54 ` jerry xzq
2025-11-22 11:32 ` Greg KH
[not found] ` <CAD48c-UjbPK4GewGpVVdEY30fhnhdAGQqrXQ3r0RgHc6suMo7Q@mail.gmail.com>
2025-11-22 12:34 ` Greg KH
2025-11-22 13:15 ` jerry xzq
2025-11-24 14:22 ` Pin-yen Lin
2025-11-24 15:51 ` Greg KH
2025-11-25 9:44 ` Pin-yen Lin
2025-11-25 11:53 ` Greg KH
2025-11-26 10:02 ` Pin-yen Lin
-- strict thread matches above, loose matches on Subject: below --
2025-11-21 8:09 Zhengqiao Xia
2025-11-21 8:28 ` Greg KH
[not found] ` <CADYyEwQqghzWedZYmZtwk1+R5DxMYg0aMJhVAutrW1w+CTB-7w@mail.gmail.com>
[not found] ` <2025112126-leverage-wrongful-85c4@gregkh>
2025-11-22 11:04 ` Zhengqiao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025112206-handwork-hush-5886@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jerry.xzq@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=treapking@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).