From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8702F25BEE8; Tue, 25 Nov 2025 11:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764071373; cv=none; b=sQ7tduMufwjiOi1wrY7FkroWvSA5Oz66j5ILR1cyeKRtR+YdOCyCORXsA2esJ7K3dLo+lWjOP8IaYk7aR/Q8NqCeRAd9rutln+ahT5PlsBgIzntg5S5I/1C1bODJwngOxe9sEo5MVNzGkU1ImsIM880GwZMwj3D95PsTqImlhFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764071373; c=relaxed/simple; bh=kcfJPaV0RlJNuRv5orxjsEuIYQsBEO264pipegKAgKM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S1uu/paE+LcCl1ebL3C8hpcol0pMIyAHIl4fCs21LVKTlQPGXRCQPKdpUASwlGZg3yRlAG9LCn1tD0w4OzBbZKKXWO/HfnTTErpimtpJe+6u6uEKvPfXm1YYiUQPJs/KSh4i8/U+V4SRiFcIBU3f993iYgi4fqz6Cvol88zU098= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RrRKFlYd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RrRKFlYd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82664C4CEF1; Tue, 25 Nov 2025 11:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764071373; bh=kcfJPaV0RlJNuRv5orxjsEuIYQsBEO264pipegKAgKM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RrRKFlYdNjpuJAzVmv+xPBFxiA66JbJHRfceWAvEnfly2ci3y3+LUqgq7ypKZ3EBu jCig9MZM3yIaUBXdD2UdwBQ+NXk4DQLPLPcSj7Zpz/ujmoxxNN0aoLYjvcXMfeqqDM 7JpcLbcGUGvGymYalc0d08j3Mz81qcwvyaIUpz2o= Date: Tue, 25 Nov 2025 12:49:29 +0100 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: Chaoyi Chen , Chaoyi Chen , Dmitry Baryshkov , Peter Chen , Luca Ceresoli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v10 01/11] usb: typec: Add notifier functions Message-ID: <2025112554-uncaring-curator-642a@gregkh> References: <20251120022343.250-1-kernel@airkyi.com> <20251120022343.250-2-kernel@airkyi.com> <2025112102-laurel-mulch-58e4@gregkh> <462ad1bd-7eec-4f26-b383-96b049e14559@rock-chips.com> <2025112402-unopposed-polio-e6e9@gregkh> <2025112448-brush-porcupine-c851@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > +static umode_t typec_is_visible(struct kobject *kobj, struct attribute *attr, int n) > +{ > + if (is_typec_port(kobj_to_dev(kobj)->parent)) Why look at the parent? Doesn't the device have a type that should show this? Otherwise, looks good to me. thanks, greg k-h