From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Łukasz Bartosik" <ukaszb@chromium.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] xhci: dbgtty: fix device unregister: fixup typo
Date: Wed, 26 Nov 2025 11:14:48 +0100 [thread overview]
Message-ID: <2025112625-uniformed-payphone-f5b3@gregkh> (raw)
In-Reply-To: <CALwA+NYBSH01FVcggf9nNbW83sRp0GH-4jKL0ByYNTM7vz-pHg@mail.gmail.com>
On Wed, Nov 26, 2025 at 08:58:10AM +0100, Łukasz Bartosik wrote:
> On Wed, Nov 26, 2025 at 8:15 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Nov 25, 2025 at 02:25:31PM +0000, Łukasz Bartosik wrote:
> > > From: Łukasz Bartosik <ukaszb@chromium.org>
> > >
> > > When DbC is disconnected then xhci_dbc_tty_unregister_device()
> > > is called. However if there is any user space process blocked
> > > on write to DbC terminal device then it will never be signalled
> > > and thus stay blocked indefinitely.
> > >
> > > This fix adds a tty_vhangup() call in xhci_dbc_tty_unregister_device().
> > > The tty_vhangup() wakes up any blocked writers and causes subsequent
> > > write attempts to DbC terminal device to fail.
> > >
> > > Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver")
> > > Signed-off-by: Łukasz Bartosik <ukaszb@chromium.org>
> > > Link: https://patch.msgid.link/20251119212910.1245694-1-ukaszb@google.com
> > >
> > > Fix typo indifinitely->indefinitely
> > >
> > > --
> > > 2.52.0.460.gd25c4c69ec-goog
> > >
> >
> > I see no patch here :(
>
> Hi Greg,
>
> The typo I fixed was in the commit message indifinitely->indefinitely.
>
> Would you please elaborate what is your expectation for a fixup in this case ?
Ah, I thought it was a change to the diff. We can't change changelogs
after they are in the tree, sorry.
thanks,
greg k-h
prev parent reply other threads:[~2025-11-26 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 14:25 [PATCH] xhci: dbgtty: fix device unregister: fixup typo Łukasz Bartosik
2025-11-26 7:15 ` Greg Kroah-Hartman
2025-11-26 7:58 ` Łukasz Bartosik
2025-11-26 9:15 ` Mathias Nyman
2025-11-26 9:50 ` Łukasz Bartosik
2025-11-26 9:56 ` Jiri Slaby
2025-11-26 12:26 ` Łukasz Bartosik
2025-11-26 14:05 ` Łukasz Bartosik
2025-11-27 14:19 ` Łukasz Bartosik
2025-11-26 10:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025112625-uniformed-payphone-f5b3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=ukaszb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox