From: Greg KH <gregkh@linuxfoundation.org>
To: Yi Cong <cong.yi@linux.dev>
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, yicong@kylinos.cn
Subject: Re: [PATCH] usb: linux/usb.h: Correct the description of the usb_device_driver member
Date: Tue, 2 Dec 2025 10:00:52 +0100 [thread overview]
Message-ID: <2025120247-gong-ranger-619c@gregkh> (raw)
In-Reply-To: <20251202065917.309025-1-cong.yi@linux.dev>
On Tue, Dec 02, 2025 at 02:59:17PM +0800, Yi Cong wrote:
> On Mon, 1 Dec 2025 10:14:04 -0500, Alan Stern <stern@rowland.harvard.edu> wrote:
> >
> > On Mon, Dec 01, 2025 at 04:53:09PM +0800, Yi Cong wrote:
> > > From: Yi Cong <yicong@kylinos.cn>
> > >
> > > In the current kernel USB device driver code, only the name field is
> > > required to be provided; all other fields are optional.
> > > Use the command grep -rnw "struct usb_device_driver" to inspect
> > > how specific drivers are declared.
> >
> > That last sentence should not be part of the patch description; it
> > doesn't explain the patch's purpose or what the patch does. (It's not
> > even correct, because the grep output doesn't show how the specific
> > drivers are declared. It mainly shows the filenames and line numbers
> > where the declarations start.)
> >
>
> Thank you for the reply!
> Do I need to update the commit message and send a new version of the patch?
Yes please.
prev parent reply other threads:[~2025-12-02 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 8:53 [PATCH] usb: linux/usb.h: Correct the description of the usb_device_driver member Yi Cong
2025-12-01 15:14 ` Alan Stern
2025-12-02 6:59 ` Yi Cong
2025-12-02 9:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025120247-gong-ranger-619c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cong.yi@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=yicong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox