public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: "Johannes Brüderl" <johannes.bruederl@gmail.com>
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v2] usb: core: add USB_QUIRK_NO_BOS for devices that hang on BOS descriptor
Date: Sun, 7 Dec 2025 10:45:05 +0100	[thread overview]
Message-ID: <20251207104505.1d5f3718.michal.pecio@gmail.com> (raw)
In-Reply-To: <CAP=XvD+dNNDj75DYjjByE3o7F8i-QxusAdz-5+hG24fCesWYRw@mail.gmail.com>

On Sun, 7 Dec 2025 10:22:41 +0100, Johannes Brüderl wrote:
> Here's the BOS Descriptor section when running w/ root.
> This is without this patch, so it "reconnected" with SuperSpeed (5Gbps).
> 
> Binary Object Store Descriptor:
>   bLength                 5
>   bDescriptorType        15
>   wTotalLength       0x0016
>   bNumDeviceCaps          2
>   USB 2.0 Extension Device Capability:
>     bLength                 7
>     bDescriptorType        16
>     bDevCapabilityType      2
>     bmAttributes   0x00000000
>       (Missing must-be-set LPM bit!)
>   SuperSpeed USB Device Capability:
>     bLength                10
>     bDescriptorType        16
>     bDevCapabilityType      3
>     bmAttributes         0x00
>     wSpeedsSupported   0x000e
>       Device can operate at Full Speed (12Mbps)
>       Device can operate at High Speed (480Mbps)
>       Device can operate at SuperSpeed (5Gbps)
>     bFunctionalitySupport   3
>       Lowest fully-functional device speed is SuperSpeed (5Gbps)
>     bU1DevExitLat           0 micro seconds
>     bU2DevExitLat           0 micro seconds
> 
> (Missing must-be-set LPM bit!) seems to be weird? As it looks like
> just nulled data.

OK, so it's broken during enumeration and after enumeration.

But that's the "fallback" case after hanging during SS+ enumeration,
which we would like to prevent from happening. What about 5gbps ports,
does it work correctly at SS or still report zero LPM?

And running at SS+ with the patch applied, does the device produce
sensible BOS descriptor? The previous one did.

What if you extend the patch to also apply at SS? It won't fix LPM
during enumeration, but would it fix the descriptor seen by lsusb?

  reply	other threads:[~2025-12-07  9:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-07  0:00 [PATCH] usb: core: add USB_QUIRK_NO_BOS for devices that hang on BOS descriptor Johannes Brüderl
2025-12-07  0:15 ` Greg KH
2025-12-07  1:20   ` [PATCH v2] " Johannes Brüderl
2025-12-07  6:19     ` Lars Melin
2025-12-07  9:02       ` [PATCH v3 1/1] " Johannes Brüderl
2026-01-07 16:06         ` Greg KH
2025-12-07  7:40     ` [PATCH v2] " Michal Pecio
2025-12-07  9:22       ` Johannes Brüderl
2025-12-07  9:45         ` Michal Pecio [this message]
2025-12-07 10:47           ` Johannes Brüderl
2025-12-07 11:00             ` Greg KH
2025-12-07 21:12               ` Greg KH
2025-12-07 22:06                 ` Michal Pecio
2025-12-08  8:58                 ` Oliver Neukum
2025-12-08 20:46                   ` Greg KH
2025-12-28 12:54                     ` Johannes Brüderl
2025-12-28 13:18                       ` Greg KH
2025-12-07  0:37 ` [PATCH] " Michal Pecio
2025-12-07  0:59   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251207104505.1d5f3718.michal.pecio@gmail.com \
    --to=michal.pecio@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes.bruederl@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox