From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6519135BDCA; Wed, 17 Dec 2025 13:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765979407; cv=none; b=OfGYnUF8COYWrACYe+D7aKwsgvCemFAVAhrev9OFVbyPiR9N0pNjsEYQd4wuw68eLQt0BsPst3Te238mAsEToGTWyZnfPAlc8nsn1xpZmA4N9+dSbh7Z2wubpADaM8L08LcYlpwOYf10/5PAtboGnCBXn9QFOMI8+mQg6xDQJOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765979407; c=relaxed/simple; bh=X6692+c3QcbH05fZoOQV/03otZa7dhkLnI0MoGOc2Ys=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qz9KfCF3OIYQghKMt1wAWKKJjEc8QUa/0AWY4pp1sJ6TWFdcGlCkdCa04F3Tba+FU62+70E5ttnpyG8IrArN8fQTAy7J/75eDjZezhHeGbvB/ZJxyB5xiFw5W3r2G0OyGAiJwdKQmvGez+S/hLM4u17Uo9mOaps4wTIj8aYx8BU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FzvE7rNG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FzvE7rNG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56367C4CEF5; Wed, 17 Dec 2025 13:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765979404; bh=X6692+c3QcbH05fZoOQV/03otZa7dhkLnI0MoGOc2Ys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FzvE7rNGjdYFj0i+A1Ud3AFOczeY0SopRwkLBqM2M3XUCtM+pZ7rR+YH80MATZGwv C1PA3VIcsHtSn2rsPbmW0CyznMeZSrFpwShfgdZ+p8WBPtFULTosP9VUNnvgY9DN8B AWM7TKseSWuIY60yc29PHCbicdn9udZINVhugzlQ= Date: Wed, 17 Dec 2025 14:50:01 +0100 From: Greg KH To: Chen Changcheng Cc: stern@rowland.harvard.edu, benjamin.tissoires@redhat.com, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] usb: usb-storage: No additional quirks need to be added to the EL-R12 optical drive. Message-ID: <2025121742-spendable-hardened-56e2@gregkh> References: <20251203071643.57058-1-chenchangcheng@kylinos.cn> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251203071643.57058-1-chenchangcheng@kylinos.cn> On Wed, Dec 03, 2025 at 03:16:43PM +0800, Chen Changcheng wrote: > The optical drive of EL-R12 has the same vid and pid as INIC-3069, > as follows: > T: Bus=02 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#= 3 Spd=5000 MxCh= 0 > D: Ver= 3.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs= 1 > P: Vendor=13fd ProdID=3940 Rev= 3.10 > S: Manufacturer=HL-DT-ST > S: Product= DVD+-RW GT80N > S: SerialNumber=423349524E4E38303338323439202020 > C:* #Ifs= 1 Cfg#= 1 Atr=80 MxPwr=144mA > I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=02 Prot=50 Driver=usb-storage > E: Ad=83(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms > E: Ad=0a(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms > > This will result in the optical drive device also adding > the quirks of US_FL_NO_ATA_1X. When performing an erase operation, > it will fail, and the reason for the failure is as follows: > [ 388.967742] sr 5:0:0:0: [sr0] tag#0 Send: scmd 0x00000000d20c33a7 > [ 388.967742] sr 5:0:0:0: [sr0] tag#0 CDB: ATA command pass through(12)/Blank a1 11 00 00 00 00 00 00 00 00 00 00 > [ 388.967773] sr 5:0:0:0: [sr0] tag#0 Done: SUCCESS Result: hostbyte=DID_TARGET_FAILURE driverbyte=DRIVER_OK cmd_age=0s > [ 388.967773] sr 5:0:0:0: [sr0] tag#0 CDB: ATA command pass through(12)/Blank a1 11 00 00 00 00 00 00 00 00 00 00 > [ 388.967803] sr 5:0:0:0: [sr0] tag#0 Sense Key : Illegal Request [current] > [ 388.967803] sr 5:0:0:0: [sr0] tag#0 Add. Sense: Invalid field in cdb > [ 388.967803] sr 5:0:0:0: [sr0] tag#0 scsi host busy 1 failed 0 > [ 388.967803] sr 5:0:0:0: Notifying upper driver of completion (result 8100002) > [ 388.967834] sr 5:0:0:0: [sr0] tag#0 0 sectors total, 0 bytes done. > > For the EL-R12 standard optical drive, all operational commands > and usage scenarios were tested without adding the IGNORE_RESIDUE quirks, > and no issues were encountered. It can be reasonably concluded > that removing the IGNORE_RESIDUE quirks has no impact. > > Signed-off-by: Chen Changcheng > --- > drivers/usb/storage/unusual_uas.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index 1477e31d7763..939a98c2d3f7 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -98,7 +98,7 @@ UNUSUAL_DEV(0x125f, 0xa94a, 0x0160, 0x0160, > US_FL_NO_ATA_1X), > > /* Reported-by: Benjamin Tissoires */ > -UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999, > +UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x0309, > "Initio Corporation", > "INIC-3069", > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > > base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449 > -- > 2.25.1 > > This does not apply to 6.19-rc1 at all :( Please rebase and resend it. thanks, greg k-h