From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Alan Stern <stern@rowland.harvard.edu>,
Ma Ke <make24@iscas.ac.cn>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 0/5] USB: lpc32xx: fix error handling
Date: Thu, 18 Dec 2025 15:19:40 +0100 [thread overview]
Message-ID: <20251218141945.5884-1-johan@kernel.org> (raw)
A recent change fixing a device reference leak introduced a clock
imbalance by reusing an error path so that the clock may be disabled
before having been enabled.
The very same change could also lead to a use-after-free in case the
driver is used with non-OF probing.
This series fixes the resulting mess as well as the device leak in the
NXP OHCI driver.
Included are also two related cleanups.
Johan
Johan Hovold (5):
usb: gadget: lpc32xx_udc: fix clock imbalance in error path
usb: phy: isp1301: fix non-OF device reference imbalance
usb: ohci-nxp: fix device leak on probe failure
usb: gadget: lpc32xx_udc: clean up probe error labels
usb: ohci-nxp: clean up probe error labels
drivers/usb/gadget/udc/lpc32xx_udc.c | 41 ++++++++++++++--------------
drivers/usb/host/ohci-nxp.c | 18 ++++++------
drivers/usb/phy/phy-isp1301.c | 7 ++++-
3 files changed, 36 insertions(+), 30 deletions(-)
--
2.51.2
next reply other threads:[~2025-12-18 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 14:19 Johan Hovold [this message]
2025-12-18 14:19 ` [PATCH 1/5] usb: gadget: lpc32xx_udc: fix clock imbalance in error path Johan Hovold
2025-12-18 14:19 ` [PATCH 2/5] usb: phy: isp1301: fix non-OF device reference imbalance Johan Hovold
2025-12-18 14:19 ` [PATCH 3/5] usb: ohci-nxp: fix device leak on probe failure Johan Hovold
2025-12-18 14:19 ` [PATCH 4/5] usb: gadget: lpc32xx_udc: clean up probe error labels Johan Hovold
2025-12-18 14:19 ` [PATCH 5/5] usb: ohci-nxp: " Johan Hovold
2025-12-18 15:09 ` Alan Stern
2025-12-18 15:20 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218141945.5884-1-johan@kernel.org \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=stern@rowland.harvard.edu \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).