From: ReBeating <rebeating@163.com>
To: gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, ReBeating <rebeating@163.com>
Subject: [PATCH] usb: cdns2: fix memory double free in cdns2_gadget_giveback
Date: Fri, 26 Dec 2025 11:17:13 +0800 [thread overview]
Message-ID: <20251226031713.1682-1-rebeating@163.com> (raw)
A patch similar to commit 5fd9e45f1ebc("usb: cdns3: fix memory double
free when handle zero packet").
As 5fd9e45f1ebc points out, the cdns2_gadget_giveback() function also has
the same memory double free issue when handling zero-length packets.
Add check for usb_gadget_giveback_request() to avoid double free of memory.
If it's additional zero length packet request, do not call
usb_gadget_giveback_request().
Signed-off-by: ReBeating <rebeating@163.com>
---
drivers/usb/gadget/udc/cdns2/cdns2-gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/cdns2/cdns2-gadget.c b/drivers/usb/gadget/udc/cdns2/cdns2-gadget.c
index 7e69944ef18a..4f7898c2e364 100644
--- a/drivers/usb/gadget/udc/cdns2/cdns2-gadget.c
+++ b/drivers/usb/gadget/udc/cdns2/cdns2-gadget.c
@@ -253,7 +253,7 @@ void cdns2_gadget_giveback(struct cdns2_endpoint *pep,
trace_cdns2_request_giveback(preq);
- if (request->complete) {
+ if (request->complete && request->buf != pdev->zlp_buf) {
spin_unlock(&pdev->lock);
usb_gadget_giveback_request(&pep->endpoint, request);
spin_lock(&pdev->lock);
--
2.34.1
next reply other threads:[~2025-12-26 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-26 3:17 ReBeating [this message]
2026-01-07 15:05 ` [PATCH] usb: cdns2: fix memory double free in cdns2_gadget_giveback Greg KH
-- strict thread matches above, loose matches on Subject: below --
2025-09-08 15:04 Chen Yufeng
2025-10-08 11:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251226031713.1682-1-rebeating@163.com \
--to=rebeating@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox