From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC4322BD586 for ; Sat, 3 Jan 2026 08:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767429185; cv=none; b=mmGls3jx55tAQASD7Ea9vTXK5tzt00NcaQF9hZ0hHQ+coA+I2HrxsB3jY95HsE5HmIoXk7V6cw3+AYAv+DrQyrb7A6AIXrOcj1Mm/klhyM9EcHCGxCznx8DgkLkf5Yak8o8N4NYUwD/Lj6BIDya3N0iEdh6CDeTgEjh1hLdXbdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767429185; c=relaxed/simple; bh=TE3kngwJ0Q/M8PG4jM5YkANzvwJ2ZBoXO6QH83Kep4E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rs/4U+WUofi1Nu2oGJfQr2GuUnBOCj9XFt8ncAlhNu77pB8lyTO7u4oAeWBbN+hYbAX7+KFpR5Ia93Cnv7x/bTKSKvS4qoYO9gTkMh95m0ym+PZzQuXvDBvH0cTs7T59eqAxsrSKYUDv3fUBLuLAeKOBH+M7ain5HU6SJ0nycPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AFOxU7nW; arc=none smtp.client-ip=209.85.214.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AFOxU7nW" Received: by mail-pl1-f193.google.com with SMTP id d9443c01a7336-2a09d981507so3586585ad.1 for ; Sat, 03 Jan 2026 00:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767429183; x=1768033983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mtp/dZW9ya4TxwOta3UUFMIrN/FXohK03+kMMLH28dY=; b=AFOxU7nWtCWWzSNkNkmJETzPS85qZfZP3Njn4VUqNOOErbFLC72SwO+B1JojwTXJqr EBwYx3xmyRzrMfY5k8olfkP7pYCVT+GVW1iKmyGT0onFEfP/J3XEpeJMa5399vmn59FC JajQE9t9vuL3/nObQcTSh5QRvujZtmR7rJpAEd1rhjv9sNsP1G8+Ngd9K8Y2tbz4gpKu C/kkwFYU7pLpZSH2jsjEPn3PiDG+1fJO4RXzayFQEskdxzk2mlQ5xaStWAh/8Ib6Zwr+ se0LuvC+Wh1SuJNOh8aSRna1I5P1JFtlNsIJstxKjuwspJiapfr//XoVPtFrSrEWpMAV 8j8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767429183; x=1768033983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mtp/dZW9ya4TxwOta3UUFMIrN/FXohK03+kMMLH28dY=; b=O2A2YWrrXxihzDpVKAfQm6zprYGrpwIi45FQbq0aXXK2pGySlTwW7Pw/E/X6ls+F5L DCzx7SEQptdYstuKnSDqXYqIeQkj6/OF7aWwZFAJ51F+Nj9FpFybN2+e3tXfBsBsXM2d 6IkaI/JQph5ym4vK3DRex/ja559lvVeP90xyO6XvYgAe3VbJtGOxx2GrPxQQNpmfoGm4 99mJ5BRyGdwvruGIFWCpp5y1AztKmjFDvR+Bi/iehBWO9XtUxDE4ZXzhpZ+UrQKM8EBI fPW4U9/ax55Yw4rV7TRTT4umjxRj+VH5cc6euXVFqsexl3A+j1cEiz3SQsH7q12T9kh5 AlDw== X-Forwarded-Encrypted: i=1; AJvYcCUH8uEuiv7W1CqKhogNI1XTDd3QhcXC4g2IH7GdsNMQePUCiAuDNwoLoHWzO6JX9x7XSgdVvqII+6o=@vger.kernel.org X-Gm-Message-State: AOJu0YwIVSt6WrYm5Cmi4iD7ENXuKDcPNOi6XVhlv6ORJtsXlJieoONS xkT1nEUiQkLqB8Xsic2wFOOjNEbaoKxSfq82rhtD7JWEju8EKYihchNq X-Gm-Gg: AY/fxX7U3y7kuBnGbo4Q1S0cFAjYJHrFJ0+BayGe3m3bAS9WDhlrVg+rbdHs+5S17oN LQHT3vUk+LAj4+RAOTYyXwBST38IUprIvkhGuEFOc+/5xncyeHv8RtYVdwvN+A3XdlQ7KSlFudT xvabyIxJkttaq6TRyZYXzdGIWRh8i4gDxzBf2e6Ffm1F/t/H/LMl0M9eUYL/bHeeyhutwwOg08N DNQ53NvzL3Fe/ZvMvdH039QocwOTUfNrCOXtn9P8MsR7JMdRCv8bc8GzxkyOJLJ9g2UI3mIaozV WOsBsbuMiftZ/mFiwUDfOjCnM59Dr2o9fjoxRdivPROSVAPnsuKza5h0vhOcQfsUZCOTKeD4Czs 3zMfBOjhFWN+cf8g8TlWXyIMblr+oq1Pp12Bl2olywVc9mkt7mFddCmwtNiwdmQigZt7jopOIh6 Ccf5ls5A== X-Google-Smtp-Source: AGHT+IF4+KGquo7ddnKSZYTeA5YRjfMxJO2/EkJueXQkQkzBA1/AjlzM6p5PsyRepGJBGL2j9Swfbw== X-Received: by 2002:a17:903:2442:b0:29f:1b1f:784 with SMTP id d9443c01a7336-2a3c0940a8bmr16854045ad.4.1767429183029; Sat, 03 Jan 2026 00:33:03 -0800 (PST) Received: from rockpi-5b ([45.112.0.8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c666d5sm391700365ad.21.2026.01.03.00.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jan 2026 00:33:02 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Heikki Krogerus , Greg Kroah-Hartman , Sebastian Reichel , Nicolas Frattaroli , FUKAUMI Naoki , Diederik de Haas , Yongbo Zhang , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list), linux-usb@vger.kernel.org (open list:USB TYPEC CLASS) Cc: Anand Moon Subject: [PATCH v1 1/3] arm64: dts: rockchip: rk3588-rock-5b-5bp-5t: Correct Type-C pin bias settings Date: Sat, 3 Jan 2026 14:01:17 +0530 Message-ID: <20260103083232.9510-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260103083232.9510-1-linux.amoon@gmail.com> References: <20260103083232.9510-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As pre FUSB302 datasheet interrupt line (INT_N) is an open-drain, active-low signal. It requires a pull-up resistor to maintain a stable high state when deasserted. Similarly, the TYPEC5V_PWREN_H enable signal requires a pull-down resistor to ensure it defaults to a low state, preventing unintended power delivery during the boot sequence. Update the pinctrl entries to use pcfg_pull_up for usbc0_int and pcfg_pull_down for vbus5v0_typec_en to align with the hardware's electrical requirements. Cc: Sebastian Reichel Fixes: 67b2c15d8fb3 ("arm64: dts: rockchip: add USB-C support for ROCK 5B/5B+/5T") Signed-off-by: Anand Moon --- v1: As per the shematics CC_INT_L interrupt pin is GPIO3_B4_u As per the shematics TYPEC5V_PWREN_H pin is GPIO2_B6_d --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi index b3e76ad2d869..0cd8ac7bf538 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-5bp-5t.dtsi @@ -537,11 +537,11 @@ pcie3_vcc3v3_en: pcie3-vcc3v3-en { usb { usbc0_int: usbc0-int { - rockchip,pins = <3 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins = <3 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>; }; vbus5v0_typec_en: vbus5v0-typec-en { - rockchip,pins = <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins = <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>; }; }; }; -- 2.50.1