Re: [PATCH v5 0/8] Add Chinese translation for USB subsystem

[BaiKefan <baikefan@leap-io-kernel.com>]

On Tue, 23 Dec 2025 21:39:41 +0800
Alex Shi <seakeel@gmail.com> wrote:

> Hi Kefan,
> 
> There are too much whitespace errors.
> Please resolve the problem and send again.
> 
> Alex
> 
> $b4 shazam 
> https://lore.kernel.org/linux-doc/cover.1765180570.git.baikefan@leap-io-kernel.com/
> 
> /home/alexshi/linux/.git/rebase-apply/patch:89: indent with spaces.
>                                  # FIXME: 确保没有人能够挂载它
> /home/alexshi/linux/.git/rebase-apply/patch:94: indent with spaces.
>          echo "We are good, connected"
> /home/alexshi/linux/.git/rebase-apply/patch:95: indent with spaces.
>          umount /mntpoint
> /home/alexshi/linux/.git/rebase-apply/patch:96: indent with spaces.
>          # 添加一些额外的内容，以便其他人也可以使用它
> /home/alexshi/linux/.git/rebase-apply/patch:98: indent with spaces.
>          echo 0 > authorized
> warning: 5 lines add whitespace errors.
> /home/alexshi/linux/.git/rebase-apply/patch:395: indent with spaces.
>           hdr = (struct ubsmon_packet *) &mmap_area[vec[i]];
> /home/alexshi/linux/.git/rebase-apply/patch:396: indent with spaces.
>           if (hdr->type == '@')     // 填充包
> /home/alexshi/linux/.git/rebase-apply/patch:397: indent with spaces.
>              continue;
> /home/alexshi/linux/.git/rebase-apply/patch:398: indent with spaces.
>           caddr_t data = &mmap_area[vec[i]] + 64;
> /home/alexshi/linux/.git/rebase-apply/patch:399: indent with spaces.
>           process_packet(hdr, data);
> warning: 5 lines add whitespace errors.
> /home/alexshi/linux/.git/rebase-apply/patch:67: indent with spaces.
>          - 3Com GmbH捐赠了一台ISDN Pro 
> TA，并在技术问题和测试设备上提供支持。
> /home/alexshi/linux/.git/rebase-apply/patch:68: indent with spaces.
>            我从未想到能获得如此慷慨的帮助。
> /home/alexshi/linux/.git/rebase-apply/patch:70: indent with spaces.
>          - USAR Systems提供了优秀的USB评估套件，使我们能够
> /home/alexshi/linux/.git/rebase-apply/patch:71: indent with spaces.
>            测试Linux USB驱动与最新USB规范的兼容性。USAR Systems
> /home/alexshi/linux/.git/rebase-apply/patch:72: indent with spaces.
>            认识到开源操作系统的重要性，并提供了硬件支持，感谢他们！
> warning: squelched 57 whitespace errors
> warning: 62 lines add whitespace errors.
> 


Hi Alex,

Sorry for the late reply — I’ve been tied up with other work recently.

Thanks for pointing this out.

I tried to reproduce the whitespace warnings you mentioned, 
but unfortunately I’m not able to see them on my side.

I tested the patch set with:

1. linux-next with the latest mainline tree
2. b4 shazam
https://lore.kernel.org/linux-doc/cover.1765180570.git.baikefan@leap-io-kernel.com/
3. scripts/checkpatch.pl --strict run on all the patch files


Given that no "indent with spaces" or other whitespace warnings
were reported, I suspect this may be environment- or tooling-related.

To help me narrow this down, could you please let me know:

1. the exact tree you are applying against (commit or branch)
2. the exact command sequence you used before running b4 shazam
3. whether any whitespace-related git config is set (e.g.
core.whitespace, apply.whitespace)


Thanks for taking the time to review this.

Thanks again
Kefan

> 
> On 2025/12/8 17:25, Kefan Bai wrote:
> > This patch set adds Chinese translations for the USB documentation.
> > 
> > Changes in v5:
> >   - Ensuring that the index.rst entries, including acm,
> > authorization, chipidea, dwc3, ehci, and usbmon, are placed in the
> > correct patches to prevent build errors when patches are applied
> > individually.
> >   - Remove extra spaces in chipidea.rst.
> >   - Send these translation patches tolinux-usb@vger.kernel.org for
> > review by Chinese-speaking developers, per Alex and Yanteng's
> > recommendation.
> > 
> > Changes in v4:
> >   - shorten those overlong title underline/overline symbols
> >   - Remove CREDITS section from index.rst
> >   - Link to
> > v4:https://lore.kernel.org/all/cover.1764674650.git.baikefan@leap-io-
> > kernel.com/
> > 
> > Changes in v3:
> >   - Updated the signoff to my full legal name,
> >     as requested by Jonathan Corbet.
> >   - Reviewed and fixed the RST syntax to resolve the patch issues
> >     noted by Alex Shi.
> >   - Kept the number of translated files to eight
> >     to make submission and review smoother.
> >   - Link to
> > v3:https://lore.kernel.org/all/cover.1763984424.git.baikefan@leap-io-
> > kernel.com/
> > 
> > Changes in v2:
> >   - Update [PATCH 01/25] docs/zh_CN: Add index.rst translation
> >     to include corresponding updates in
> >     Documentation/translations/zh_CN/subsystem-apis.rst.
> >   - Link to
> > v2:https://lore.kernel.org/all/cover.1763897036.git.baikefan@leap-io-
> > kernel.com/
> > 
> > v1:
> >   -
> > Link:https://lore.kernel.org/all/20251123074540.34161-1-baikefan@leap-io-
> > kernel.com/
> > 
> > Kefan Bai (8):
> >    docs/zh_CN: Add index.rst translation
> >    docs/zh_CN: Add acm.rst translation
> >    docs/zh_CN: Add authorization.rst translation
> >    docs/zh_CN: Add chipidea.rst translation
> >    docs/zh_CN: Add dwc3.rst translation
> >    docs/zh_CN: Add ehci.rst translation
> >    docs/zh_CN: Add usbmon.rst translation
> >    docs/zh_CN: Add CREDITS translation
> > 
> >   .../translations/zh_CN/subsystem-apis.rst     |   2 +-
> >   Documentation/translations/zh_CN/usb/CREDITS  | 153 +++++++
> >   Documentation/translations/zh_CN/usb/acm.rst  | 137 +++++++
> >   .../translations/zh_CN/usb/authorization.rst  | 125 ++++++
> >   .../translations/zh_CN/usb/chipidea.rst       | 142 +++++++
> >   Documentation/translations/zh_CN/usb/dwc3.rst |  60 +++
> >   Documentation/translations/zh_CN/usb/ehci.rst | 216 ++++++++++
> >   .../translations/zh_CN/usb/index.rst          |  54 +++
> >   .../translations/zh_CN/usb/usbmon.rst         | 380
> > ++++++++++++++++++ 9 files changed, 1268 insertions(+), 1
> > deletion(-) create mode 100644
> > Documentation/translations/zh_CN/usb/CREDITS create mode 100644
> > Documentation/translations/zh_CN/usb/acm.rst create mode 100644
> > Documentation/translations/zh_CN/usb/authorization.rst create mode
> > 100644 Documentation/translations/zh_CN/usb/chipidea.rst create
> > mode 100644 Documentation/translations/zh_CN/usb/dwc3.rst create
> > mode 100644 Documentation/translations/zh_CN/usb/ehci.rst create
> > mode 100644 Documentation/translations/zh_CN/usb/index.rst create
> > mode 100644 Documentation/translations/zh_CN/usb/usbmon.rst
> > 
> > --
> > 2.52.0
> > 
> 
> 
>