From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
Cc: Andreas Noever <andreas.noever@gmail.com>,
Mika Westerberg <westeri@kernel.org>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: log path activation failures without WARN backtraces
Date: Mon, 5 Jan 2026 12:16:57 +0100 [thread overview]
Message-ID: <20260105111657.GL2275908@black.igk.intel.com> (raw)
In-Reply-To: <20260102031905.27416-1-acelan.kao@canonical.com>
On Fri, Jan 02, 2026 at 11:19:05AM +0800, Chia-Lin Kao (AceLan) wrote:
> tb_path_activate() currently logs failures with tb_WARN(), which triggers
> a stack trace. Transient conditions such as lane bonding or Type-C link
> hiccups can fail path activation briefly, and the resulting backtraces are
> noisy without aiding diagnosis.
>
> Switch to tb_warn() for all path activation failures. The error code is
> already returned to callers, and the warning still shows the message
> without the backtrace.
>
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Applied to thunderbolt.git/next, thanks!
prev parent reply other threads:[~2026-01-05 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 3:19 [PATCH] thunderbolt: log path activation failures without WARN backtraces Chia-Lin Kao (AceLan)
2026-01-05 11:16 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105111657.GL2275908@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=acelan.kao@canonical.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox